unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform
https://platform.uno
Apache License 2.0
170 stars 32 forks source link

[Android] `NavigationBar` SecondaryCommands empty without Label #1484

Open morning4coffe-dev opened 2 months ago

morning4coffe-dev commented 2 months ago

This is out of the box from the template where I picked the Fluent Design, I've only added the AppBarButton in Secondary Commands UnoApp5.zip Screenshot 2024-09-18 171024 Screenshot 2024-09-18 171130

Originally posted by @WenHong-Lau in https://github.com/unoplatform/uno/discussions/18233#discussioncomment-10679488

This seems to be an issue on newer Android versions.

WenHong-Lau commented 1 month ago

Actually this happens on light theme as well, could not see the text in the SecondaryCommands

kazo0 commented 1 month ago

@WenHong-Lau / @morning4coffe-dev Does anything show up if you set the Label property of the AppBarButtons?

morning4coffe-dev commented 1 month ago

@kazo0 Jup, this does work correctly with Label... but it should probably at least show the icon of the AppBarButton.

@WenHong-Lau You can use something like this to display the SecondaryCommand properly:

AppBarButton Icon="Add" Label="Add"/>
WenHong-Lau commented 1 month ago

Still not showing on my end. image

morning4coffe-dev commented 1 month ago

@WenHong-Lau And when you set only the Label and not the Content?

WenHong-Lau commented 1 month ago

@morning4coffe-dev Tested that, still the same outcome, not visible.

morning4coffe-dev commented 1 month ago

Interesting... I did try it yesterday and it showed. I will make a repro, if you can try it on your side. Thanks.

morning4coffe-dev commented 1 month ago

Here is what I see on my side with Android API 34:

image

Here is the repro. Can you try on your side? NavigationBar.zip

WenHong-Lau commented 1 month ago

Can you try it on dark mode? I still can't see the AppBarButtons image

morning4coffe-dev commented 1 month ago

Ok, I see it as well again. Thank you, @WenHong-Lau. I make a new issue to track both problems.