search

unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform
https://platform.uno
Apache License 2.0
168 stars 30 forks source link

[Material] Ripple effect review #579

Open kazo0 opened 3 years ago

kazo0 commented 3 years ago

Current behavior

Ripple effect seems to be too quick. Ensure KeyFrame here times make sense.

Uno: ripple-uno

Flutter: ripple-flutter

Expected behavior

Ripple effect should match Material guidance. We can use the Flutter values as a reference

How to reproduce it (as minimally and precisely as possible)

Press on Button/Card in Gallery

vincentcastagna commented 2 years ago

Duplicate ? https://github.com/unoplatform/Uno.Themes/issues/627

agneszitte commented 2 years ago

Ripple effect needs to be reviewed.

627 is closed, we will update this issue with new comments while working on it.

We compare what we have at the moment with Flutter values as a reference.