[Material][Texbox] there should be some space between text and delete button

unoplatform / Uno.Themes

This library is designed to help you use the Material, Fluent or Cupertino design system with the Uno Platform

https://platform.uno

Apache License 2.0

170 stars 32 forks source link

[Material][Texbox] there should be some space between text and delete button #603

Open MaximeDion-Work opened 3 years ago

MaximeDion-Work commented 3 years ago

What would you like to be added:

I would like to add some margin t make it so the text is not too close to the delete button when text is long

Why is this needed:

It would look cleaner

For which Platform:

[x] UWP
[x] iOS
[x] Android
[x] WebAssembly
[x] macOS

Anything else we need to know?

matizk144 commented 1 year ago

Hello, nice feature, which is some cases could be as bug. Imagine small textbox which show some digits. Is any way to disable (hide) X button in some cases, to release space for X button? or always I need to reservce space fo X button?

jeromelaban commented 1 year ago

@kazo0

kazo0 commented 1 year ago

good catch @matizk144!

Are you by any chance still using the V1 version of Uno.Material? What's the version of the Uno.Material NuGet package that is installed?

By default, the Clear button should be automatically hidden once the TextBox gets small enough. So, in the screenshot below, we have a Material Design 3 TextBox, a Material Design 2 TextBox, and a default Fluent TextBox. You can see that the Fluent TextBox has content and is focused but shows no Clear button.

The issue you're seeing, I believe, is fixed in the "V2" Uno.Material styles

matizk144 commented 1 year ago

Hello @kazo0, yes, I still use V1. I used Nuget 2.3.0. Maybe it's time to switch to V2 :) Issue not happen in V2.