WPF fails to build due to CS0433 when MSAL is included

MartinZikmund commented 1 year ago

Current behavior

Trying to build

Expected behavior

How to reproduce it (as minimally and precisely as possible)

Run Wizard
Select Blank template and Customize
Add Skia WPF platform
Add MSAL authentication
Create
Try to build the solution
Build fails with C:\Dev\Throwaway\UnoApp17\UnoApp17.Skia.WPF\Uno.UI.SourceGenerators\Uno.UI.SourceGenerators.BindableTypeProviders.BindableTypeProvidersSourceGenerator\BindableMetadata.g.cs(13228,88,13228,100): error CS0433: The type 'CoreWebView2' exists in both 'Microsoft.Web.WebView2.Core, Version=1.0.864.35, Culture=neutral, PublicKeyToken=2a8ab48044d2601e' and 'Uno.UI, Version=255.255.255.255, Culture=neutral, PublicKeyToken=null'

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

[ ] iOS
[ ] Android
[ ] WebAssembly
[ ] WebAssembly renders for Xamarin.Forms
[ ] Windows
[ ] Build tasks

Visual Studio:

[ ] 2017 (version: )
[ ] 2019 (version: )
[ ] for Mac (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

MartinZikmund commented 1 year ago

CC @jeromelaban

jeromelaban commented 1 year ago

That one is going to be difficult to fix, both types may effectively exist at the same time...

nickrandolph commented 1 year ago

Is this an issue with the template or specifically with MSAL? On the template, perhaps we should restrict targets to only those that we know work with MSAL?

MartinZikmund commented 12 months ago

@nickrandolph @jeromelaban maybe it would make sense to prevent selecting MSAL if WPF is also selected (at least for now). Otherwise we get bad user experience now with the solution not building out of the box. Or we find a way to implement MSAL on WPF without WebView2. @carldebilly might know?

nickrandolph commented 12 months ago

Yeh I had this on my backlog for wizard/template to prevent msal if not supported platforms are selected. I just need to spend some time verifying which platforms are working.

nickrandolph commented 11 months ago

Closing as duplicate of https://github.com/unoplatform/uno.templates/issues/426 where not supported platforms are included by template

unoplatform / uno.extensions