unoplatform / uno.resizetizer

The home for Uno.Resizetizer, an image resizting tooling for Uno Platform apps
https://platform.uno
Other
15 stars 6 forks source link

Svg clean up improvements #257

Closed pedrojesus-work closed 1 month ago

pedrojesus-work commented 1 month ago

Fixes: #256

On the first interaction on #219, we thought that should be enough to look up the ContentFilesProjectOutputGroupOutput only, but we ignored the case where the user may have the a svg with the same name used as UnoImage, but in another location, something like:

<UnoImage Include="Assets/Images/car.svg />
<Content Include="Assets/SVG/car.svg" />

On the current version, the SVG/car.svg will not be packaged, because its name matches with the UnoImage version. With this PR the SVG/car.svg will be packaged, because it checks the fullpath.

But still, the same asset can't be used as UnoImage and Content, and this limitation is because we can't know if that was caused by some Uno task or the user want it, and when we have that it could cause unexpected behavior, see #218 for more context on it.

PR Type

pedrojesus-work commented 1 month ago

@dansiegel, I believe this will be fixed on https://github.com/unoplatform/uno/pull/16593, but I believe it's a good idea to merge this one, since it improves the look-up on Resizetizer target, but I'll left the decision to you