search

unoplatform / uno.templates

Uno Platform project templates
https://platform.uno/
Other
16 stars 9 forks source link

`TargetFrameworks` should be better as a single line #654

Closed Youssef1313 closed 2 months ago

Youssef1313 commented 2 months ago

image

If someone decided to do <CompilerVisibleProperty Include="TargetFrameworks" /> for some reason, the multi-line will break Roslyn. The way compiler-visible properties are passed to the compiler is by generating an .editorconfig file. But Roslyn will not handle this case properly (known limitation).

NOTE: I know it's not common at all that someone makes TargetFrameworks a compiler-visible property (usually people would care about TargetFramework). But if someone decided to do it. It will break badly.

jeromelaban commented 2 months ago

I agree. It's causing more trouble than the readability it improves.

eriklimakc commented 2 months ago

Does this mean updating all the samples migrated and in migration process to use single line tfms?

cc @agneszitte @jeromelaban

dansiegel commented 2 months ago

@eriklimakc yes it would be good to update the samples to use a single line for the tfms