unoplatform / uno.templates

Uno Platform project templates
https://platform.uno/
Other
16 stars 9 forks source link

fix: change comment to be JSON valid #768

Closed spouliot closed 1 week ago

spouliot commented 1 week ago

GitHub Issue (If applicable): closes #767

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The global.json file used for templates is NOT valid JSON - since comments are not allowed in the format.

What is the new behavior?

Comment was changed to fit the JSON format.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

jojorne commented 1 week ago

Comments in global.json files are supported using JavaScript or C# style comments. - Comments in global.json

If all, I'd just break it into multiple lines to make it easier to read:

{
  // To update the version of Uno please update the version of the Uno.Sdk here.
  // See https://aka.platform.uno/upgrade-uno-packages for more information.
  "msbuild-sdks": {
    "Uno.Sdk": "$UnoSdkVersion$"
  }
}
jeromelaban commented 1 week ago

@mergifyio backport release/stable/5.2

mergify[bot] commented 1 week ago

backport release/stable/5.2

🟠 Waiting for conditions to match

- [ ] `merged` [📌 backport requirement]
jeromelaban commented 1 week ago

@mergifyio backport release/stable/5.3

mergify[bot] commented 1 week ago

backport release/stable/5.3

🟠 Waiting for conditions to match

- [ ] `merged` [📌 backport requirement]
jeromelaban commented 1 week ago

Let's not merge this one, we'll use the jsonc config.