unoplatform / uno.todo

Uno Platform "Uno To Do" reference app
https://platform.uno/
Other
47 stars 12 forks source link

Update ToDo to latest Uno #513

Open kazo0 opened 1 year ago

kazo0 commented 1 year ago

We should be updating ToDo to latest stable packages for all Uno family packages and then ensure the app is working correctly

@nickrandolph Did you have a pending PR or branch that was already in the midst of doing this?

nickrandolph commented 1 year ago

https://github.com/unoplatform/uno.todo/tree/dev/nr/workingupdate Here's the branch I had that updated various nuget packages. Would be a starting point for anyone looking to update this repo

GitHub
GitHub - unoplatform/uno.todo at dev/nr/workingupdate
Uno Platform "Uno To Do" reference app. Contribute to unoplatform/uno.todo development by creating an account on GitHub.
Arieldelossantos commented 1 year ago

hey @nickrandolph i'm updating the Project with the new Uno template, but i'm having this weird build error... something related to WinForms support

`1> Target ResolveRuntimePackAssets: _1> C:\Program Files\dotnet\sdk\7.0.302\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(448,5): error NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App.WindowsForms available for the specified RuntimeIdentifier 'win10-arm'.

1> C:\Program Files\dotnet\sdk\7.0.302\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(448,5): error NETSDK1082: There was no runtime pack for Microsoft.WindowsDesktop.App.WindowsForms available for the specified RuntimeIdentifier 'win10-arm-aot'._

1> Done building target "ResolveRuntimePackAssets" in project "ToDoXYZ.csproj" -- FAILED. 1> 1> Done building project "ToDoXYZ.csproj" -- FAILED.`

do you have any idea??

cc: @kazo0 @carlh98

HakanL commented 1 year ago

@Arieldelossantos I ran into this same error in my project, I solved this by adding this to my class library project file, named Shared, don't know if it's the correct fix, but worth a shot:

    <PropertyGroup Condition="$(IsWinAppSdk)">
        <RuntimeIdentifiers>win10-x64;win10-x86</RuntimeIdentifiers>
    </PropertyGroup>
Arieldelossantos commented 1 year ago

that worked! thanks

nickrandolph commented 1 year ago

You shouldn't have a shared project any more and I think the class library should already have the runtimeidentifiers specified. Are you trying to update in-place, or are you creating a new solution and copying files across?

Arieldelossantos commented 1 year ago

i've added a new project and updating the files to later remove the old one

HakanL commented 1 year ago

You shouldn't have a shared project any more and I think the class library should already have the runtimeidentifiers specified. Are you trying to update in-place, or are you creating a new solution and copying files across?

I used a new template from a few weeks ago and the class library did not have the runtime identifier in it.