search

unoplatform / uno.toolkit.ui

A set of custom controls for the WinUI and the Uno Platform not offered out of the box by WinUI, such as Card, TabBar, NavigationBar, etc.
https://platform.uno/
MIT License
82 stars 27 forks source link

include xml doc in the nuget package #331

Open Xiaoy312 opened 2 years ago

Xiaoy312 commented 2 years ago

What would you like to be added:

<GenerateDocumentationFile>true</GenerateDocumentationFile>

Why is this needed:

^ title

For which Platform: Build tasks

Anything else we need to know?

should also add:

<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsNotAsErrors Condition="'$(Configuration)'=='Debug'">$(WarningsNotAsErrors);CS1591</WarningsNotAsErrors>

to enforce doc along with other forms of disconformities: nullable etc...

Xiaoy312 commented 2 years ago

TreatWarningsAsErrors probably deserve its own issue, since that a beast itself

Youssef1313 commented 2 years ago

I'm adding <TreatWarningsAsErrors>true</TreatWarningsAsErrors> in #334