unoplatform / uno.toolkit.ui

A set of custom controls for the WinUI and the Uno Platform not offered out of the box by WinUI, such as Card, TabBar, NavigationBar, etc.
https://platform.uno/
MIT License
83 stars 27 forks source link

Top half of Fab TabBarItem is not clickable #76

Open kazo0 opened 3 years ago

kazo0 commented 3 years ago

Blocked by https://github.com/unoplatform/uno/issues/7393

Current behavior

Given a MaterialBottomTabBar with with one of the Items using the MaterialFabTabBarItemStyle, the translated button is only clickable for the portion of the FAB that is still "inside" the TabBar itself.

Expected behavior

Entire FAB should be clickable

How to reproduce it (as minimally and precisely as possible)

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

Visual Studio:

Relevant plugins:

Anything else we need to know?

agneszitte commented 3 years ago

I will verify if we don't have another solution / workaround for this issue

kazo0 commented 2 years ago

Reopened by https://github.com/unoplatform/uno.toolkit.ui/pull/286

agneszitte commented 2 years ago

Reopened by #286

@kazo0 this can be closed again right, as #286 is now closed right?

agneszitte commented 1 year ago

@kazo0 maybe you can take a look at this one and check the status of this issue please

Youssef1313 commented 1 year ago

@agneszitte-nventive I can confirm it's still not clickable :'(

Youssef1313 commented 1 year ago

@agneszitte-nventive It looks like the workaround you added in https://github.com/unoplatform/uno.toolkit.ui/pull/183 no longer exists. Is it possible to re-add it for the current v2 styles?

kazo0 commented 1 year ago

@Youssef1313 I believe that the old workaround was the cause of this issue: https://github.com/unoplatform/uno.toolkit.ui/issues/273

So we decided the top half of the FAB being unclickable was the lesser of two evils :(

Maybe if we layered the TabBar on top of the rest of the page content we wouldn't get this ugly visual bug, but I'm not sure if it would cause problems with touches not falling through to the content underneath