search

unoplatform / uno.ui.runtimetests.engine

In-App MS Tests Runner for Uno Platform and WinAppSDK
https://platform.uno/
Other
7 stars 3 forks source link

Add ImageAssert Helpers #87

Closed kazo0 closed 10 months ago

kazo0 commented 1 year ago

Migrate assertion helpers from Uno's runtime tests such as the ImageAssert

Not sure if we'd want to create a separate Helpers package like we do for Uno.UITest or it'd just be simpler to include within the main runtime test engine package.

jeromelaban commented 1 year ago

It feels like adding those in Uno.UITest is more interesting. I'll move the issue.

kazo0 commented 1 year ago

@jeromelaban this would mean you'd need to use the Uno.UITest package in your runtime test project even if you aren't writing UI Tests, no?

The thing is, there's ImageAssert for RuntimeTests but also ImageAssert for UITests in the Uno repo

We could probably hopefully merge them and have something like the RawBitmap class be able to handle the info from RenderTargetBitmap as well as the ScreenshotInfo type from Uno.UITest

But it's fuzzy to me where this logic should live or if we should be keeping ImageAssert logic separate, one for Runtime Tests and one for UI Tests

jeromelaban commented 1 year ago

Ah you're right, I mixed up the two :) The issue was at the right place.