fix: Properly merge namespaces

Youssef1313 commented 1 year ago

Thanks @MartinZikmund for the help here!

PR Type

What kind of change does this PR introduce?

Please check if your PR fulfills the following requirements:

[ ] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Internal Issue (If applicable):

Youssef1313 commented 1 year ago

It looks like I broke an existing test 😕 Also extended the existing test with more cases and it is broken. I'll debug again.

MartinZikmund commented 1 year ago

Seems good!

Youssef1313 commented 1 year ago

@jeromelaban @MartinZikmund Is this ready to merge?