unoplatform / uno.xamlmerge.task

https://platform.uno/
Other
7 stars 4 forks source link

test: add a test that produces an ArgumentOutOfBoundsException but shouldn't #132

Closed ramezgerges closed 1 year ago

ramezgerges commented 1 year ago

GitHub Issue (If applicable): unoplatform/uno#12787

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

jeromelaban commented 1 year ago

The build is failing with CSC : error CS1617: Invalid option '11' for /langversion. Use '/langversion:?' to list supported values., looks like we may need to adjust the version based on the targetframework.

Youssef1313 commented 1 year ago

The CI installs .NET 6 which comes with compiler support to C# 10.

We can either use <LangVersion>10</LangVersion> or update CI to use .NET 7

jeromelaban commented 1 year ago

Looking good, thanks @ramezgerges!

welcome[bot] commented 1 year ago

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋