search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.65k stars 699 forks source link

Separate Uno.UI.Toolkit to its own package #10933

Open Youssef1313 opened 1 year ago

Youssef1313 commented 1 year ago

Currently, Uno.UI can be referenced in Windows builds, but only Uno.UI.Toolkit is in the package:

image

For UAP, the package only contains Uno.UI.Toolkit. The rest of the package isn't used.

I think it makes sense to separate Uno.UI.Toolkit to its own NuGet package. For Windows projects/builds, we will only include Uno.UI.Toolkit instead of the whole Uno.UI package.

This can result in faster restore when building UAP only.

That will be part of https://github.com/unoplatform/uno/issues/10302

MartinZikmund commented 11 months ago

Could be part of 5x breaking changes

MartinZikmund commented 11 months ago

Ideally we should also avoid naming the package Uno.UI.Toolkit to avoid confusion with Uno Toolkit.

Youssef1313 commented 11 months ago

I recall discussing this with @jeromelaban but I don't recall the outcome. @jeromelaban Did we want to do this for Uno 5?

MartinZikmund commented 11 months ago

I think we didn't want to rename the assembly itself, but we are ok with naming the package differently and maybe even the namespaces within, but better confirm

jeromelaban commented 11 months ago

Indeed, renaming the assembly can cause more trouble than it fixes. Creating a package may be interesting, though dependencies may be tricky (as well as the upgrade path). Let's see how 5x goes first.