search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.74k stars 705 forks source link

Separate Skia UWP and WinUI tests to different stages #13761

Open MartinZikmund opened 11 months ago

MartinZikmund commented 11 months ago 
          I'm not sure about the impact of this change on CI times.

The skia_tests stage now runs tests for both UWP and WinUI flavors, but only WinUI run will depend on convert_tree stage. So, this will delay UWP flavor test run unnecessarily. Is it not significant that we can live with it, or do we need to split skia_tests to two stages, where one stage (UWP flavor) depends only on Setup, while the other (WinUI flavor) depends on both Setup and convert_tree?

_Originally posted by @Youssef1313 in https://github.com/unoplatform/uno/pull/13749#discussion_r1334005590_

MartinZikmund commented 9 months ago

The same is applicable for other platforms as well (WASM already is UWP + WinUI, but in the future we definitely want to run at least runtime tests on WinUI, including mobile)