Closed ahmed605 closed 3 months ago
@ahmed605 This one is concerning though -
Seems like it happens sometime during snapshot tests. You can try to run them locally using this button :
Just let it run and hopefully it will fail locally the same way.
This one is concerning though -
@MartinZikmund I think this is because the SkSL thing under Software Rendering, I disabled SkSL on software rendering locally so it should be fixed.
I will try that button and see if it still fails after the fix
The build 96915 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 81, ios
: 182, ios-Snap
: 627, skia-gtk-screenshots
: 21, skia-wpf-screenshots
: 20, wasm
: 29, wasm-automated-net7.0-UWP-Benchmarks
: 0, wasm-automated-net7.0-UWP-Default
: 35, wasm-automated-net7.0-UWP-RuntimeTests
: 0, wasm-automated-net7.0-WinUI-RuntimeTests
: 0
The build 97142 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 70, ios
: 71, ios-Snap
: 315, skia-gtk-screenshots
: 24, skia-wpf-screenshots
: 21, wasm
: 28, wasm-automated-net7.0-UWP-Benchmarks
: 0, wasm-automated-net7.0-UWP-Default
: 35, wasm-automated-net7.0-UWP-RuntimeTests
: 0, wasm-automated-net7.0-WinUI-RuntimeTests
: 0
The build 97650 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 83, ios
: 121, ios-Snap
: 422, skia-gtk-screenshots
: 18, skia-wpf-screenshots
: 22, wasm
: 28, wasm-automated-net7.0-UWP-Benchmarks
: 0, wasm-automated-net7.0-UWP-Default
: 36, wasm-automated-net7.0-UWP-RuntimeTests
: 0, wasm-automated-net7.0-WinUI-RuntimeTests
: 0
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
The build 110114 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 61, ios
: 221, ios-Snap
: 839, skia-gtk-screenshots
: 19, skia-wpf-screenshots
: 17, wasm
: 27, wasm-automated-net7.0-UWP-Default-automated
: 36, wasm-automated-net7.0-UWP-RuntimeTests-0
: 0, wasm-automated-net7.0-UWP-RuntimeTests-1
: 0, wasm-automated-net7.0-UWP-RuntimeTests-2
: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0
@ahmed605 As the AcrylicBrush
cannot be directly tested in CI, can you please add a runtime test that verifies, that the brush uses the FallbackColor
when HW acceleration is not enabled?
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
The build 110284 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 58, ios
: 83, ios-Snap
: 673, skia-gtk-screenshots
: 24, skia-wpf-screenshots
: 21, wasm
: 62, wasm-automated-net7.0-UWP-Default-automated
: 37, wasm-automated-net7.0-UWP-RuntimeTests-0
: 0, wasm-automated-net7.0-UWP-RuntimeTests-1
: 0, wasm-automated-net7.0-UWP-RuntimeTests-2
: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0
@jeromelaban Can you re-check this one please? @ahmed605 added a runtime test to validate Acrylic brush, so the public part of this one should be covered now
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
The build 114058 found UI Test snapshots differences: android-28-net7
: 1, android-28-net7-Snap
: 52, ios
: 118, ios-Snap
: 440, skia-gtk-screenshots
: 22, skia-wpf-screenshots
: 19, wasm
: 80, wasm-automated-net7.0-UWP-Default-automated
: 30, wasm-automated-net7.0-UWP-RuntimeTests-0
: 1, wasm-automated-net7.0-UWP-RuntimeTests-1
: 0, wasm-automated-net7.0-UWP-RuntimeTests-2
: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-13812/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-13812/index.html
The build 115035 found UI Test snapshots differences: android-28-net7
: 0, android-28-net7-Snap
: 85, ios
: 33, ios-Snap
: 138, skia-gtk-screenshots
: 19, skia-wpf-screenshots
: 19, wasm
: 55, wasm-automated-net7.0-UWP-Default-automated
: 32, wasm-automated-net7.0-UWP-RuntimeTests-0
: 0, wasm-automated-net7.0-UWP-RuntimeTests-1
: 0, wasm-automated-net7.0-UWP-RuntimeTests-2
: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1
: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2
: 0
GitHub Issue (If applicable): closes #10828
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This PR implements the following APIs and effects:
[no screenshot]
[no screenshot]
[no screenshot]
[no screenshot]
[no screenshot]
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 4a47c01
This pull request adds a new sample page
EffectBrushTests
to demonstrate the use ofCompositionEffectBrush
in Uno, and enhances the support for this feature on Skia. It also improves theBasicAcrylicBrushTest
sample by adding some UI controls and layout. To achieve this, it introduces several new classes and enums that implement the Win2D graphics effects API, and modifies some existing classes to handle the effect creation and rendering.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
To implement the missing blend modes and exceptions mentioned below we need SkiaSharp to update its bindings to include
SKImageFilters::RuntimeShader
andSKColorFilters::Lerp
, then that can be done once we upgrade to Skia 3 since these APIs don't exist in Skia 2. (cc. @mattleibow)All effects are tested against Windows ones, pretty much all of them (with few unnoticeable exceptions) are 1:1 match