Closed qhj closed 8 months ago
Thanks for reporting this @qhj
Could you specify the version of Uno you are using? Font-fallback support was added in https://github.com/unoplatform/uno/pull/14287 (available starting from 5.1.0-dev.937), and it may help with your scenario.
@Youssef1313 Thanks for your work! I updated project dependencies, confirm that font fallback support works on prerelease version of uno.
But I cannot test the second problem, TextBox().Text()
font size changes on focus/blur. I have now found that the blurred TextBox()
does not display text and the program crashes when I input text.
https://github.com/unoplatform/uno/assets/59396128/a43a2407-597d-4403-b855-a80e5bc26071
While updating dependencies by issuing Update-Package -IncludePrerelease
in Package Manager Console, NuGet complained Update-Package : Sequence contains no matching element
. NuGet/Home#13069
I don't know if only some of dependencies are updated to prerelease version or if there are bugs in the prereleased packages.
@qhj Could you upload the project? It will help investigating this crash.
@qhj Could you upload the project? It will help investigating this crash.
That crash is due to mismatching version that happened when NuGet crashed and failed to update all dependencies. This PR fixes that: https://github.com/qhj/UnoApp1/pull/1
@Youssef1313 Thank you very much!
The problem that TextBox().Text()
font size changes on focus/blur seems to haven't been fixed yet. I will modify description of this issue.
@qhj does it repro if you use the fluent theme instead?
@jeromelaban Yes.
Found a new problem that placeholder text and input text are not vertically centered on WinUI (fluent theme). As shown below.
Created a new repo, https://github.com/qhj/unoApp2
@qhj Thanks for the update. It's best to attach a zip of the sample, as the repository is not public at this time, but you may also remove it in the future. Thanks!
@jeromelaban Sorry, I forgot to make the repo pubilic, it's public now. And here is the zip file of this repo.
The problem with vertical alignment is tracked in https://github.com/unoplatform/uno/issues/14705 and should be fixed with https://github.com/unoplatform/uno/pull/13810. As for the size changing: For a regular TextBox, it seems to be working fine and the size isn't changing, but there are differences in FontWeight between focused and unfocused states. It's mostly a limitation with SkiaSharp and/or Gtk and is being partially tracked in https://github.com/unoplatform/uno/issues/13725. As for PasswordBox, the size change turned out not be a size change, but a glyph change. We were mistakenly using • in the unfocused passwordbox, and ● in the focused passwordbox (provided by GTK) instead of ● in both.
Current behavior
https://github.com/unoplatform/uno/assets/59396128/eaa56625-2c73-4b67-91ef-7005feb63d8a
Expected behavior
https://github.com/unoplatform/uno/assets/59396128/b6bff185-acaa-4123-9dbb-3efc2bdf68c7
How to reproduce it (as minimally and precisely as possible)
clone https://github.com/qhj/UnoApp1 and run the Skia.Gtk head project
Workaround
No response
Works on UWP/WinUI
Yes
Environment
Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
NuGet package version(s)
No response
Affected platforms
Skia (GTK on Linux/macOS/Windows)
IDE
Visual Studio 2022
IDE version
17.8.4
Relevant plugins
No response
Anything else we need to know?
No response