search

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.09k stars 739 forks source link

Verify if EVP works properly for `ScrollView` #15853

Open Youssef1313 opened 8 months ago

Youssef1313 commented 8 months ago

What would you like to be added

If it doesn't work, we may need to RegisterAsScrollPort, but then have to special case it in hit test as we don't want ScrollOffsets to affect HitTest (because HitTest already works correctly)

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response

Youssef1313 commented 8 months ago

ScrollPresenter actually already calls RegisterAsScrollPort, so this is likely already working as expected. It needs tests to confirm though.

dr1rrb commented 8 months ago

ScrollPresenter actually already calls RegisterAsScrollPort, so this is likely already working as expected. It needs tests to confirm though.

I would assume not with the current implementation of the "effective viewport": we rely on the internal ScrollOffsets property. We probably need either to change the effective viewport to rely on the Visual properties, either the ScrollPresenter to set our own internal property :)

Youssef1313 commented 8 months ago

We have EffectiveViewportScrollPresenterTests that are now under #if false. These tests should be enabled and fixed :)