search

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
8.89k stars 720 forks source link

Uno.UI can't be compiled under VS 2019.3 #1601

Closed MartinZikmund closed 5 years ago

MartinZikmund commented 5 years ago

Current behavior

Compiling Uno.UI under VS 2019.3 crashes with a number of errors:

1>C:\Users\Martin.nuget\packages\msbuild.sdk.extras\1.6.68\Build\LanguageTargets\CheckMissing.targets(36,5): error : The specified language targets for MonoAndroid90 is missing. Ensure correct tooling is installed for 'MonoAndroid'. Missing: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Bindings.targets' 1>Done building project "Uno.UI.BindingHelper.Android.csproj" -- FAILED. 1>C:\Users\Martin.nuget\packages\msbuild.sdk.extras\1.6.68\Build\LanguageTargets\CheckMissing.targets(36,5): error : The specified language targets for MonoAndroid80 is missing. Ensure correct tooling is installed for 'MonoAndroid'. Missing: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Bindings.targets' 1>Done building project "Uno.UI.BindingHelper.Android.csproj" -- FAILED. 1>C:\Users\Martin.nuget\packages\msbuild.sdk.extras\1.6.68\Build\LanguageTargets\CheckMissing.targets(36,5): error : The specified language targets for xamarinios10 is missing. Ensure correct tooling is installed for 'xamarinios'. Missing: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\iOS\Xamarin.iOS.CSharp.targets' 1>Done building project "Uno.UI.BindingHelper.Android.csproj" -- FAILED. 1>C:\Users\Martin.nuget\packages\msbuild.sdk.extras\1.6.68\Build\LanguageTargets\CheckMissing.targets(36,5): error : The specified language targets for xamarinmac20 is missing. Ensure correct tooling is installed for 'xamarinmac'. Missing: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\Mac\Xamarin.Mac.CSharp.targets' 1>Done building project "Uno.UI.BindingHelper.Android.csproj" -- FAILED.

Expected behavior

Should not crash

How to reproduce it (as minimally and precisely as possible)

Try to compile Uno.UI under VS 2019.3

Environment

Nuget Package: -

Package Version(s): -

Affected platform(s):

Visual Studio

Relevant plugins

Anything else we need to know?

The problem is caused by old version of MSBuild.Sdk.Extras used: https://github.com/onovotny/MSBuildSdkExtras/issues/178

MartinZikmund commented 5 years ago

Same problem occurs when trying to build a Uno-based app with Uno class library, which also uses older version of MSBuild.Sdk.Extras. The project template needs to be updated as well

ghuntley commented 5 years ago

Related to https://github.com/unoplatform/uno/pull/1572

MartinZikmund commented 5 years ago

Thanks, did not notice this one

ghuntley commented 5 years ago

nps.

jeromelaban commented 5 years ago

Fixed by #1572