Fix potential github action smells

ceddy4395 commented 2 weeks ago

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

Hey! 🙂 I want to contribute the following changes to your workflow:

These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more

Please check if your PR fulfills the following requirements:

[ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Validated PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
[ ] Commits must be following the Conventional Commits specification.

Internal Issue (If applicable):

CLAassistant commented 2 weeks ago

All committers have signed the CLA.

jeromelaban commented 2 weeks ago

@ceddy4395 also note we're using conventional commits, you'll need to rewrite your commits using this convention (see the PR template).

ceddy4395 commented 2 weeks ago

@jeromelaban, thanks for pointing that out :see_no_evil: I've rewritten the commit messages!

unodevops commented 2 weeks ago

jeromelaban commented 1 week ago

@ceddy4395 it looks like specifying the base path entirely is required:

ceddy4395 commented 3 days ago

@jeromelaban Yes I see, thanks for the feedback, I've reverted those changes.

unodevops commented 3 days ago

unodevops commented 2 days ago