unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.45k stars 685 forks source link

fix: Fix WinUI SamplesApp not setting main window correctly #16533

Closed Youssef1313 closed 2 weeks ago

Youssef1313 commented 2 weeks ago

GitHub Issue (If applicable): closes #16532

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16533/index.html

unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16533/index.html

nventive-devops commented 2 weeks ago

The build 123416 found UI Test snapshots differences: android-28-net7: 15, android-28-net7-Snap: 61, ios: 121, ios-Snap: 413, skia-gtk-screenshots: 26, skia-linux-screenshots: 26, skia-windows-screenshots: 22, wasm: 84, wasm-automated-net7.0-UWP-Default-automated: 24, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net7`: **15** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `When_InListView_after_scroll` - `When_InScrollViewer_after_scroll` - `WebView_NavigateToAnchor_Initial` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage`
* `android-28-net7-Snap`: **61** changed over 1063
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons` - `ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal` - `TextBlock_Attributed_text_Supserscript_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_Supserscript` - `ListView_ListView_Expandable_Item_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item` - `Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_Clipping_UITests_Windows_UI_Input_PointersTests_HitTest_Clipping` - `Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_Control_UITests_Windows_UI_Input_PointersTests_HitTest_Control` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `ListView_ListViewChangeView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeView` - `MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage` - `MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest` - `ListView_HorizontalListViewTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewTest` - `MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension`
* `ios`: **121** changed over 271
🚨🚨 Comparison Details (first 20) 🚨🚨 - `CheckBox_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated` - `Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox` - `ListView_ExpandableItemLarge_ExpandHeaderWithSingleItem_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large` - `ListView_ExpandableItem_ExpandSingleItem_Initial_State` - `ListView_ExpandableItem_ExpandSingleItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item` - `TextBox_MaxLength_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_MaxLength` - `CheckBox_IsEnabled_StatePreservation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated` - `FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text` - `ListView_ExpandableItem_ExpandMultipleItems_Expanded_State` - `ListView_ObservableCollection_Creation_Count_Removed_above` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `StaticResource_Converter_Validation_UITests_Shared_Resources_StaticResource_StaticResource_Simple` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `Button_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_Automated` - `Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `FlyoutTest_When_NoOverlayInputPassThroughElement_Then_DontPassThrough_woOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox` - `ListView_ExpandableItemLarge_ExpandHeaderWithMultipleItems_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Expandable_Item_Large` - `ListView_ExpandableItem_ExpandSingleItem_Collapsed_State`
* `ios-Snap`: **413** changed over 1054
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Animations_DoubleAnimation_opacity_final_state_UITests_Windows_UI_Xaml_Media_Animation_DoubleAnimation_FinalState_Opacity` - `Animations_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill_UITests_Windows_UI_Xaml_Media_Animation_ColorAnimationUsingKeyFrames_Fill` - `AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Keyboard_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBox_Keyboard` - `Buttons_UITests_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton2450_UITests_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton2450` - `ComboBox_ComboBox_DropDownWidth_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownWidth` - `Default_UITests_Windows_UI_Xaml_Controls_Canvas_Grid_ZIndex_UITests_Windows_UI_Xaml_Controls_Canvas_Grid_ZIndex` - `Default_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Dropdown_Background_4418_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Dropdown_Background_4418` - `Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage` - `ItemsRepeater_UITests_Windows_UI_Xaml_Controls_Repeater_UniformGridLayout_Simple_UITests_Windows_UI_Xaml_Controls_Repeater_UniformGridLayout_Simple` - `Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_Dismissal` - `Keyboard_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events` - `MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage` - `MUX_MUXControlsTestApp_PersonPicturePage_MUXControlsTestApp_PersonPicturePage` - `MUX_MUXControlsTestApp_RefreshContainerOnImagePage_MUXControlsTestApp_RefreshContainerOnImagePage` - `MUX_MUXControlsTestApp_RefreshContainerPage_MUXControlsTestApp_RefreshContainerPage` - `Path_HorizontalAlignmentStretchVerticalAlignmentBottom_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_HorizontalAlignmentStretchVerticalAlignmentBottom` - `Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush` - `Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry`
* `skia-gtk-screenshots`: **26** changed over 2182
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BorderImageBrush.png` - `ColorPickerSample.png-dark` - `ColorPickerSample.png` - `XamlRoot_Properties.png-dark` - `XamlRoot_Properties.png` - `CalendarView_Theming.png-dark` - `CalendarView_Theming.png` - `Using .mkv.png-dark` - `Using .mkv.png` - `MediaPlayerElement_Stretch_Fill.png-dark` - `MediaPlayerElement_Stretch_Fill.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `BorderImageBrush.png-dark` - `Using .avi.png-dark` - `Using .avi.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `SwipeControlPage2.png-dark` - `SwipeControlPage2.png`
* `skia-linux-screenshots`: **26** changed over 2182
🚨🚨 Comparison Details (first 20) 🚨🚨 - `CalendarView_Theming.png` - `CalendarView_Theming.png-dark` - `ImageBrushStretch2.png-dark` - `ImageBrushStretch2.png` - `MediaPlayerElement_Stretch_Fill.png-dark` - `MediaPlayerElement_Stretch_Fill.png` - `LoadedImageSurface.png-dark` - `LoadedImageSurface.png` - `Mini player.png-dark` - `Mini player.png` - `SvgImageSource_NoSize.png-dark` - `SvgImageSource_NoSize.png` - `Using .avi.png-dark` - `Using .avi.png` - `Using .flv.png-dark` - `Using .flv.png` - `Using .mkv.png-dark` - `Using .mkv.png` - `Using .mov.png-dark` - `Using .mov.png`
* `skia-windows-screenshots`: **22** changed over 2182
🚨🚨 Comparison Details (first 20) 🚨🚨 - `CalendarView_Theming.png-dark` - `Ellipse.png-dark` - `Ellipse.png` - `BorderImageBrush.png-dark` - `BorderImageBrush.png` - `CalendarView_Theming.png` - `Image_Stretch_None.png-dark` - `Image_Stretch_None.png` - `Image_Stretch_None_ScrollViewer.png-dark` - `Image_Stretch_None_ScrollViewer.png` - `StretchNoneBoundingBoxInDoubleStackPanel.png-dark` - `StretchNoneBoundingBoxInDoubleStackPanel.png` - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `Rectangle.png-dark` - `Rectangle.png` - `Uniform100x100.png-dark` - `Uniform100x100.png`
* `wasm`: **84** changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨 - `UITests.Windows_UI_Xaml_Controls.ListView.ListView_DuplicateItem` - `GenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateX` - `MUXControlsTestApp.NavigationViewItemTemplatePage` - `GenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateX` - `MUXControlsTestApp.NavigationViewMenuItemStretchPage` - `MUXControlsTestApp.RefreshVisualizerPage` - `SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigation` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListViewGrouped` - `SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_TextBox` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderFooter_ImplicitlyBinded` - `UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.PasswordBoxTests.PasswordBoxPage` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Margin_On_Container` - `UITests.Windows_UI_ViewManagement.ApplicationViewSizing`
* `wasm-automated-net7.0-UWP-Default-automated`: **24** changed over 1962
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Check_ListView_Swallows_Measure_after_scroll` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Default_StrokeThickness_MyLine_0_StrokeThickness` - `Default_StrokeThickness_MyPolygon` - `LoopingSelector_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short_UITests_Windows_UI_Xaml_Controls_LoopingSelectorTests_LoopingSelector_Short` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `Transform_TransformToVisual_Translate2d_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_TransformToVisual_Translate2d` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features` - `When_Padding_Is_Changed_Then_Cache_Is_Missed_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCache` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **0** changed over 1