search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.45k stars 685 forks source link

fix: Don't fail build on an empty library #16534

Closed jeromelaban closed 2 weeks ago

jeromelaban commented 2 weeks ago

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno/issues/16524

PR Type

What kind of change does this PR introduce?

What is the new behavior?

Ensures that a library without any eligible Content builds properly.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

jeromelaban commented 2 weeks ago

@mergifyio backport release/stable/5.2

mergify[bot] commented 2 weeks ago

backport release/stable/5.2

✅ Backports have been created

* [#16555 fix: Don't fail build on an empty library (backport #16534)](https://github.com/unoplatform/uno/pull/16555) has been created for branch `release/stable/5.2`
unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16534/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16534/index.html

nventive-devops commented 2 weeks ago

The build 123436 found UI Test snapshots differences: android-28-net7: 22, android-28-net7-Snap: 48, ios: 128, ios-Snap: 534, skia-gtk-screenshots: 37, skia-linux-screenshots: 36, skia-windows-screenshots: 12, wasm: 55, wasm-automated-net7.0-UWP-Default-automated: 24, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 1

Details * `android-28-net7`: **22** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_BitmapIcon_Generic_Changed` - `When_BitmapIcon_Generic_Initial` - `When_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_InScrollViewer_after_scroll` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `WebView_NavigateToAnchor_Initial` - `When_InListView_after_scroll`
* `android-28-net7-Snap`: **48** changed over 1063
🚨🚨 Comparison Details (first 20) 🚨🚨 - `TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage` - `GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons` - `TextBlock_TextBlock_CharacterSpacing_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_CharacterSpacing` - `TextBlock_TextBlock_Hyperlink_Touch_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Hyperlink_Touch` - `TextBlock_TextBlock_Hyperlink_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Hyperlink` - `TextBlock_TextBlock_Inlines_TemplatedParent_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Inlines_TemplatedParent` - `ListView_ListViewHeaderFooterOnly_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooterOnly` - `Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup` - `Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_Image_UITests_Windows_UI_Input_PointersTests_HitTest_Image` - `Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss` - `TextBlock_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Width_UITests_Windows_UI_Xaml_Media_GradientBrushTests_LinearGradientBrush_Width` - `ListView_ListViewScrollIntoViewSnapPoints_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollIntoViewSnapPoints` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout` - `MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing` - `MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension`
* `ios`: **128** changed over 271
🚨🚨 Comparison Details (first 20) 🚨🚨 - `FocusManager_FocusDirection_Right_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection` - `Image_Source_Nullify_image_source_nullify_empty` - `ListView_ObservableCollection_Creation_Count_Added` - `Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1` - `Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-2` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `ItemsControl_ItemContainerStyle_ItemsControl_ItemContainerStyle` - `ListView_ObservableCollection_Creation_Count_Scrolled2` - `Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-3` - `Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-0` - `TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners` - `TextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection` - `When_FontWeight_Changed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic` - `Check_CornerRadius_Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Toggle` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `ItemsControl_AppendItem_UITests_Windows_UI_Xaml_Controls_ItemsControl_ItemsControl_AppendItem` - `Large_Image_With_Margin_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Margin_Large` - `Screenshots_Image_Stretch_Alignment_Wider_Mode-0` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage`
* `ios-Snap`: **534** changed over 1054
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap` - `Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush` - `Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill` - `Buttons_Simple_TextBlockButton_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_TextBlockButton` - `Buttons_ToggleButton_IsEnabled_Automated_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleButton_IsEnabled_Automated` - `ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent` - `ContentControl_ContentControl_WithInlineContent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_WithInlineContent` - `Dialogs_UITests_Shared_MessageDialogTests_MessageDialogTest_UITests_Shared_MessageDialogTests_MessageDialogTest` - `Dialogs_UITests_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_Dialogs_UITests_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_Dialogs` - `Flyouts_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage` - `Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource` - `Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout` - `Grid_Grid_left_column_Auto_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_left_column_Auto` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_MultiLoad_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_MultiLoad` - `ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped` - `ListView_ListViewLegacy_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewLegacy` - `ListView_ListViewMarginTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewMarginTest` - `ListView_ListViewResizableText_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListViewResizableText` - `ListView_ListViewResizable_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewResizable`
* `skia-gtk-screenshots`: **37** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `BorderImageBrushRelativeTransform.png` - `XamlRoot_Properties.png-dark` - `XamlRoot_Properties.png` - `PanelImageBrush.png-dark` - `PanelImageBrush.png` - `BorderImageBrushRelativeTransform.png-dark` - `Uniform100x100.png-dark` - `Uniform100x100.png` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png` - `ImageBrushInList.png-dark` - `ImageBrushInList.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `Ellipse.png-dark` - `Ellipse.png` - `Native.png-dark` - `Native.png`
* `skia-linux-screenshots`: **36** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `AutomationProperties_Name.png-dark` - `AutomationProperties_Name.png` - `ImageBrushAlignmentXY.png-dark` - `ImageBrushAlignmentXY.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `Ellipse.png-dark` - `Ellipse.png` - `ImageBrush_StreamSource.png-dark` - `ImageBrush_StreamSource.png` - `Mini player.png-dark` - `Mini player.png` - `MediaPlayerElement_Stretch_Fill.png-dark` - `MediaPlayerElement_Stretch_Fill.png` - `LoadedImageSurface.png-dark` - `LoadedImageSurface.png` - `LargeImageList.png-dark` - `LargeImageList.png` - `ListView_IsSelected.png-dark` - `ListView_IsSelected.png`
* `skia-windows-screenshots`: **12** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ColorPickerSample.png` - `ColorPickerSample.png-dark` - `Mini player.png-dark` - `Mini player.png` - `SwipeControlPage2.png-dark` - `SwipeControlPage2.png` - `Uniform100x100.png-dark` - `Uniform100x100.png` - `Using .flv.png-dark` - `Using .flv.png` - `XamlRoot_Properties.png-dark` - `XamlRoot_Properties.png`
* `wasm`: **55** changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨 - `GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode` - `MUXControlsTestApp.NavigationViewStretchPage` - `UITests.Windows_UI_Xaml.UIElementTests.UIElement_MeasureDirtyPath` - `MUXControlsTestApp.PaneLayoutTestPage` - `UITests.Windows_UI_ViewManagement.ApplicationViewSizing` - `UITests.Windows_UI_ViewManagement.UISettingsTests` - `MUXControlsTestApp.RefreshVisualizerPage` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderFooter_ImplicitlyBinded` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_TransformsOnList` - `Uno.UI.Samples.Content.UITests.Animations.DoubleAnimation_Cumulative` - `MUXControlsTestApp.NavigationViewAnimationPage` - `MUXControlsTestApp.NavigationViewCustomThemeResourcesPage` - `MUXControlsTestApp.SwipeControlPage2` - `UITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_Fill` - `UITests.Windows_UI_Xaml_Media_Animation.DoubleAnimation_FinalState_Opacity` - `UITests.Windows_UI_Xaml_Media_Animation.DoubleAnimation_FinalState_Transforms` - `Uno.UI.Samples.Content.UITests.CommandBar.CommandBar_Examples` - `UITests.Microsoft_UI_Xaml_Controls.RatingControlTests.RatingControlPage` - `UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataTemplateSelector`
* `wasm-automated-net7.0-UWP-Default-automated`: **24** changed over 1962
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `Pickers_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload` - `MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry` - `Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage` - `TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_TransformToVisual_Transform_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Transform` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **1** changed over 1
🚨🚨 Comparison Details (first 20) 🚨🚨 - `RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage`