search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.45k stars 685 forks source link

Pixel rounding on wasm #16544

Closed dr1rrb closed 1 week ago

dr1rrb commented 2 weeks ago

Current behavior

Standard size image

Full screen: image

On Firefox grid does not appear at all, no matter the scaling

Expected behavior

Grid visiblity is concsistent no matter the scaling

How to reproduce it (as minimally and precisely as possible)

https://github.com/unoplatform/Uno.Samples/pull/675

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

dr1rrb commented 2 weeks ago

@agneszitte

agneszitte commented 2 weeks ago

Did a quick test with @dr1rrb and we noticed that when changing the color for one cell (using Chrome DevTools here) we have this result: image image

agneszitte commented 2 weeks ago

My version on WASM - Display 100% Tested with Chrome, Chrome Canary, Edge, and Firefox

    "Uno.Sdk": "5.2.108"
    <UnoExtensionsVersion>4.1.14</UnoExtensionsVersion>
    <UnoToolkitVersion>6.0.18</UnoToolkitVersion>
    <UnoThemesVersion>5.0.13</UnoThemesVersion>
    <UnoCSharpMarkupVersion>5.2.13</UnoCSharpMarkupVersion>

image

And here are the results on the other platforms using the same versions:

agneszitte commented 1 week ago

@dr1rrb closing this issue as we talked about the other day since we can see the lines on Windows as well. It is related to the current implementation of this sample with ItemsRepeater + Viewbox. Feel free to adjust the issue if needed