search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.45k stars 685 forks source link

fix(reg): Fix InteractionTracker regression when it has null Owner #16551

Closed Youssef1313 closed 2 weeks ago

Youssef1313 commented 2 weeks ago

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16551/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16551/index.html

Youssef1313 commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 2 pipeline(s).
unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16551/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16551/index.html

nventive-devops commented 2 weeks ago

The build 123649 found UI Test snapshots differences: android-28-net7: 23, android-28-net7-Snap: 55, ios: 228, ios-Snap: 706, skia-gtk-screenshots: 29, skia-linux-screenshots: 56, skia-windows-screenshots: 18, wasm: 79, wasm-automated-net7.0-UWP-Default-automated: 24, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net7`: **23** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `FocusManager_GetFocusedElement_CheckBox_LostFocus_Validation_FocusManager_-_LostFocus_-_CheckBox_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_CheckBox_LostFocus_Validation_FocusManager_-_LostFocus_-_CheckBox_-_3_-_Click_outside` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `Pivot_Non_PivotItemChange_Validation_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `When_InListView_after_scroll` - `When_InScrollViewer_after_scroll` - `When_BitmapIcon_Generic_Changed` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_BitmapIcon_Generic_Initial` - `When_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic` - `NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `WebView_NavigateToLongString_AfterSuccess` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `PopupWithOverlay_UITests_Shared_Windows_UI_Xaml_Controls_Popup_Popup_Overlay_On` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch`
* `android-28-net7-Snap`: **55** changed over 1063
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage` - `Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground` - `Keyboard_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage` - `MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension` - `MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension` - `MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension` - `MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension` - `RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage` - `TextBox_Input_Simple_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Simple` - `Pointers_TappedEventTest_Uno_UI_Samples_Samples_Shared_Content_UITests_TappedEventTest` - `Pointers_TouchRotated_Uno_UI_Samples_Content_UITests_TouchEventsTests_TouchRotated` - `Pointers_Touch_Uno_UI_Samples_Content_UITests_TouchEventsTests_Touch` - `Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage` - `Image_StretchNoneBoundingBoxInDoubleStackPanel_Uno_UI_Samples_UITests_ImageTestsControl_StretchNoneBoundingBoxInDoubleStackPanel` - `MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal`
* `ios`: **228** changed over 271
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BasicExpressionTest_UITests_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBox_ExpressionTest` - `Change_Manipulation_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property` - `ComboBoxTests_Kidnapping_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_ComboBoxItem_Selection` - `FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOn_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `InputScope_Should_Not_Validate_Input_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_CurrencyAmount` - `Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox` - `Screenshots_Image_Stretch_Alignment_Equal_Mode-1` - `Screenshots_Image_Stretch_Alignment_Equal_Mode-2` - `ScrollViewer_Content_Margin_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Content_Margin` - `ScrollViewer_Removed_And_Added_Initial-Scrolled` - `ScrollViewer_Removed_And_Added_Initial` - `TextBox_Foreground_Color_Changing_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Foreground_Changing` - `TextBox_TextAlignment_Justify_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment` - `TextBox_TextAlignment_Left_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment` - `When_FontWeight_Changed_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_FontWeight_Dynamic` - `CheckBox_IsEnabled_StatePreservation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated` - `ComboBoxTests_ToggleDisabled_ComboBox_Enabled` - `FocusManager_FocusDirection_Left_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection` - `Image_Source_Nullify_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Source_Nullify` - `Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox`
* `ios-Snap`: **706** changed over 1054
🚨🚨 Comparison Details (first 20) 🚨🚨 - `AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion` - `Border_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmargins` - `Border_Border_Simple_No_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background` - `Border_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderWithNullBrushAndNonZeroThickness` - `Brushes_ImageBrushAlignmentXY2_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY2` - `Brushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay` - `Brushes_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage_UITests_Windows_UI_Xaml_Media_GradientBrushTests_GradientsPage` - `Buttons_Simple_TextBlockButton_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_TextBlockButton` - `Buttons_UITests_Shared_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton_IsEnabled_Automated_UITests_Shared_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton_IsEnabled_Automated` - `Buttons_UITests_Shared_Windows_UI_Xaml_Controls_RepeatButton_Automated_UITests_Shared_Windows_UI_Xaml_Controls_RepeatButton_Automated` - `Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping` - `ComboBox_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement_UITests_Shared_Windows_UI_Xaml_Controls_ComboBox_ComboBox_DropDownPlacement` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_IsSelected` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `Default_UITests_Windows_UI_Xaml_Controls_Canvas_Grid_ZIndex_UITests_Windows_UI_Xaml_Controls_Canvas_Grid_ZIndex` - `Default_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Dropdown_Background_4418_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Dropdown_Background_4418` - `Default_Uno_UI_Samples_UITests_Image_Image_Margin_Uno_UI_Samples_UITests_Image_Image_Margin` - `Default_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSize` - `Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_UIElement_ContextFlyout`
* `skia-gtk-screenshots`: **29** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `UIElement_ContextFlyout.png-dark` - `UIElement_ContextFlyout.png` - `LargeImageList.png-dark` - `LargeImageList.png` - `Mini player.png-dark` - `Mini player.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `ImageBrushInList.png-dark` - `ImageBrushInList.png` - `Using .mov.png-dark` - `Using .mov.png` - `CompositionEffectBrush.png-dark` - `CompositionEffectBrush.png` - `SvgImageSource_Icons.png-dark` - `SvgImageSource_Icons.png` - `Using .avi.png-dark` - `Using .avi.png` - `Using .ogg.png-dark` - `Using .ogg.png`
* `skia-linux-screenshots`: **56** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `ImageBrush_UniformToFill.png-dark` - `ImageBrush_UniformToFill.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `BorderImageBrushRelativeTransform.png` - `Ellipse.png-dark` - `Ellipse.png` - `ImageWithLateSourceUniformToFill.png-dark` - `ImageWithLateSourceUniformToFill.png` - `ImageBrushInList.png-dark` - `ImageBrushInList.png` - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `CompositionEffectBrush.png-dark` - `CompositionEffectBrush.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `BorderImageBrushRelativeTransform.png-dark`
* `skia-windows-screenshots`: **18** changed over 2192
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BorderImageBrush.png-dark` - `Ellipse.png-dark` - `Ellipse.png` - `BorderImageBrush.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `Image_Stretch_None_ScrollViewer.png-dark` - `Image_Stretch_None_ScrollViewer.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `Rectangle.png-dark` - `Rectangle.png` - `SvgImageSource_FromStream.png-dark` - `SvgImageSource_FromStream.png` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png` - `XamlRoot_Properties.png-dark` - `XamlRoot_Properties.png`
* `wasm`: **79** changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨 - `GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode` - `MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage` - `MUXControlsTestApp.RadialGradientBrushPage` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Changing_Text` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item` - `UITests.Windows_UI_Xaml_Media_Animation.ColorAnimationUsingKeyFrames_Fill` - `UITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_Background` - `UITests.Windows_UI_Xaml_Media_Animation.ColorAnimation_Fill` - `UITests.Windows_UI_Xaml_Media_Animation.DoubleAnimation_FinalState_Opacity` - `UITests.Windows_UI_Xaml_Media_Animation.DoubleAnimation_FinalState_Transforms` - `UITests.Windows_UI_Xaml_Media_Animation.FadeInOutThemeAnimationPage` - `GenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateX` - `GenericApp.Views.Content.UITests.Animations.DoubleAnimation_RenderTransformOrigin` - `UITests.Shared.Windows_Devices.Midi.MidiDeviceEnumerationTests` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Ogg_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Stretch_Fill` - `UITests.Shared.Windows_UI_Xaml_Input.Keyboard.Keyboard_Showing_Dismissal` - `MUXControlsTestApp.HierarchicalNavigationViewMarkup`
* `wasm-automated-net7.0-UWP-Default-automated`: **24** changed over 1962
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Pickers_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload` - `Check_ListView_Swallows_Measure_after_scroll` - `MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension` - `Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path` - `TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_FillRule` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry` - `Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **0** changed over 1