feat: introduce a new BorderVisual to handle rendering the border and the background - Githubissues

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.

https://platform.uno

Apache License 2.0

8.51k stars 690 forks source link

feat: introduce a new BorderVisual to handle rendering the border and the background #16562

Closed ramezgerges closed 4 weeks ago

ramezgerges commented 1 month ago

This fixes a bunch of rendering problems in borders and simplifies the logic significantly.

GitHub Issue (If applicable): closes #16518, closes #16294

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Validated PR Screenshots Compare Test Run results.
[ ] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
[ ] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

ramezgerges commented 1 month ago

Before: After (uno left, winui right):

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html

unodevops commented 1 month ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

unodevops commented 4 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16562/index.html

unodevops commented 4 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16562/index.html