search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.48k stars 690 forks source link

feat: Enable `ToolTips` on Skia by default #16649

Closed MartinZikmund closed 3 weeks ago

MartinZikmund commented 3 weeks ago

GitHub Issue (If applicable): related to https://github.com/unoplatform/uno/issues/10791, related to #15796

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Tooltips are disabled on Skia by default

What is the new behavior?

Enabled

PR Checklist

Please check if your PR fulfills the following requirements:

unodevops commented 3 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16649/index.html

unodevops commented 3 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16649/index.html

nventive-devops commented 3 weeks ago

The build 124399 found UI Test snapshots differences: android-28-net7: 21, android-28-net7-Snap: 51, ios: 169, ios-Snap: 408, skia-gtk-screenshots: 19, skia-linux-screenshots: 38, skia-windows-screenshots: 32, wasm: 78, wasm-automated-net7.0-UWP-Default-automated: 21, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 1

Details * `android-28-net7`: **21** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `FlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_1_-_Initial_State` - `FrameworkElement_NativeLayout_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_NativeLayout` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `When_InListView_after_scroll` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_InScrollViewer_after_scroll` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_2_-_Click_outside` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage`
* `android-28-net7-Snap`: **51** changed over 1065
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ListView_HorizontalListViewTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewTest` - `ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates` - `Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing` - `GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable_Uno_UI_Samples_Content_UITests_GridView_GridViewGroupedResizable` - `GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData` - `MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension` - `MediaPlayerElement_Using_avi_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Avi_Extension` - `MediaPlayerElement_Using_flv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Flv_Extension` - `MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension` - `TextBox_Input_InputScope_CurrencyAmount_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_CurrencyAmount` - `TextBox_Input_InputScope_Email_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_Email` - `Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents` - `ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped` - `TextBox_Uno_UI_Samples_UITests_TextBoxControl_TextBox_IsReadOnly_Uno_UI_Samples_UITests_TextBoxControl_TextBox_IsReadOnly` - `MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage` - `MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage` - `Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics`
* `ios`: **169** changed over 269
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Check_CornerRadius_Border_CornerRadius=5` - `Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-0` - `Screenshots_Image_Stretch_Algmnt_Inf_Vertical_Mode-1` - `ScrollViewer_Clipping_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Clipping` - `ScrollViewer_Content_Margin_After-Scrolled` - `ScrollViewer_WhenSync_RunNormalAndCompletesWithNonIntermediate_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_UpdatesMode` - `TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners` - `TextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection` - `When_CustomContentAndLongTitle_TitleShouldNotOverlapBarButtons_OnNavigateBack_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_LongTitle_CommandBar_Frame` - `When_CustomContent_CommandBarTitleShouldBeVisible_NativeFrame_UITests_Windows_UI_Xaml_Controls_CommandBar_CustomContent_CommandBar_Frame` - `When_Target_Is_Set_After_Start_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty` - `Change_Manipulation_Property_After_property_change` - `Check_CornerRadius_Border_No_CornerRadius` - `ComboBoxTests_Fullscreen_Popup_iOS_Opened` - `ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None` - `Image_Invalid_image_invalid_before_hide` - `Screenshots_Image_Stretch_Alignment_Bigger_Mode-0` - `TextBox_BeforeTextChanging_Validation_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_BeforeTextChanging` - `TextBox_Foreground_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Foreground` - `PasswordBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Simple`
* `ios-Snap`: **408** changed over 1056
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Buttons_AppBarButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonTest` - `Buttons_Button_UseUWPDefaultStyles_UITests_Shared_Windows_UI_Xaml_Controls_Button_Button_UseUWPDefaultStyles` - `Buttons_Hyperlink_Button_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Hyperlink_Button` - `Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsBasicPage` - `Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsFocusPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsFocusPage` - `ComboBox_ComboBox_NativePopup_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ComboBox_ComboBox_NativePopup` - `FrameworkElement_UITests_Windows_UI_Xaml_FrameworkElementTests_DynamicBackgroundSizing_UITests_Windows_UI_Xaml_FrameworkElementTests_DynamicBackgroundSizing` - `FrameworkElement_UITests_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_Opacity_UITests_Windows_UI_Xaml_FrameworkElementTests_FrameworkElement_Opacity` - `Grid_GridWithColumnSpan_Uno_UI_Samples_Content_UITests_GridTestsControl_GridWithColumnSpan` - `Grid_Grid_Auto_Center_Cell_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_Auto_Center_Cell` - `Grid_Grid_with_Text_VerticalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_VerticalAlignment_With_Margin` - `Grid_Grid_with_three_UserControl_With_5_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_three_UserControl_With_5_Margin` - `Grid_Grid_with_UILabel_TextAlignmentVertical_Bottom_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UILabel_TextAlignmentVertical_Bottom` - `Grid_Grid_with_UserControl_HorizonalAlignment_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_UserControl_HorizonalAlignment` - `ListView_ListView_Header_DataContextChanging_UITests_Shared_Windows_UI_Xaml_Controls_ListView_Header_DataContextChanging` - `ListView_ListView_Infinite_Breadth_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Infinite_Breadth` - `Microsoft_UI_Composition_UITests_Windows_UI_Composition_MixTransformCliPropertyAndClippedByParentWithBorders_Then_RenderingIsValid_UITests_Windows_UI_Composition_MixTransformCliPropertyAndClippedByParentWithBorders_Then_RenderingIsValid` - `Microsoft_UI_Composition_UITests_Windows_UI_Composition_TransformElementClippedByParentWithBorder_Then_ClippingAppliedPostRendering_UITests_Windows_UI_Composition_TransformElementClippedByParentWithBorder_Then_ClippingAppliedPostRendering` - `Microsoft_UI_Composition_UITests_Windows_UI_Composition_TransformElementClippedByParent_Then_ClippingAppliedPostRendering_UITests_Windows_UI_Composition_TransformElementClippedByParent_Then_ClippingAppliedPostRendering` - `Microsoft_UI_Composition_UITests_Windows_UI_Composition_Vector3KeyFrameAnimationSample_UITests_Windows_UI_Composition_Vector3KeyFrameAnimationSample`
* `skia-gtk-screenshots`: **19** changed over 2198
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageBrush_SameWithDelay.png-dark` - `XamlRoot_Properties.png-dark` - `XamlRoot_Properties.png` - `ImageBrush_SameWithDelay.png` - `Path_Geometries.png-dark` - `Path_Geometries.png` - `Mini player.png-dark` - `Mini player.png` - `WinUIColorPickerPage.png-dark` - `WinUIColorPickerPage.png` - `Rectangle.png-dark` - `Rectangle.png` - `Using .avi.png-dark` - `Using .avi.png` - `SvgImageSource_Icons.png` - `ImageBrush_UniformToFill.png-dark` - `ImageBrush_UniformToFill.png` - `Using .mkv.png-dark` - `Using .mkv.png`
* `skia-linux-screenshots`: **38** changed over 2198
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageBrushAlignmentXY2.png-dark` - `ImageBrushAlignmentXY2.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `ImageBrush_StreamSource.png-dark` - `ImageBrush_StreamSource.png` - `ImageBrushStretch2.png-dark` - `ImageBrushStretch2.png` - `ListView_IsSelected.png-dark` - `ListView_IsSelected.png` - `CompositionEffectBrush.png-dark` - `CompositionEffectBrush.png` - `Image_Stretch_None.png-dark` - `Image_Stretch_None.png` - `Image_Formats.png-dark` - `Image_Formats.png` - `Mini player.png-dark` - `Mini player.png` - `SvgImageSource_NoSize.png-dark` - `SvgImageSource_NoSize.png`
* `skia-windows-screenshots`: **32** changed over 2198
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `DoubleImageBrushInList.png-dark` - `DoubleImageBrushInList.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `ImageSourceUrlMsAppDataScheme.png-dark` - `ImageSourceUrlMsAppDataScheme.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `Image_Stretch_None.png-dark` - `Image_Stretch_None.png` - `StretchNoneBoundingBoxInDoubleStackPanel.png-dark` - `StretchNoneBoundingBoxInDoubleStackPanel.png` - `SvgImageSource_NoSize.png-dark` - `SvgImageSource_NoSize.png` - `Rectangle.png-dark` - `Rectangle.png`
* `wasm`: **78** changed over 1047
🚨🚨 Comparison Details (first 20) 🚨🚨 - `GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode` - `MUXControlsTestApp.HierarchicalNavigationViewMarkup` - `MUXControlsTestApp.NavigationViewRS3Page` - `SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_Automated` - `UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewItemsSourceTests` - `UITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPage` - `UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_Selection` - `Uno.UI.Samples.Content.UITests.GridView.GridViewVariableItemHeight` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems` - `UITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarSimple` - `UITests.Shared.Microsoft_UI_Xaml_Controls.TwoPaneViewTests.TwoPaneViewPage` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Flv_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_Extension` - `UITests.Windows_UI_Xaml_Controls.TextBox.TextBox_IsTabStop` - `Uno.UI.Samples.Content.UITests.TextBoxControl.Input_Test_InsideScrollerViewer_Automated` - `Uno.UI.Samples.Content.UITests.TextBoxControl.Input_Test_NoScrollViewer_Automated` - `initial_state` - `GenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateX`
* `wasm-automated-net7.0-UWP-Default-automated`: **21** changed over 1964
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage_UITests_Windows_UI_Xaml_DragAndDrop_DragDrop_TestPage` - `Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Default_StrokeThickness_MyPolygon` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries` - `Performance_Dopes_UITests_Windows_UI_Xaml_Performance_Performance_Dopes` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `Windows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTests`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **1** changed over 1
🚨🚨 Comparison Details (first 20) 🚨🚨 - `RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage`