Investigate Padding interaction with borders and border backgrounds

ramezgerges commented 1 month ago

Current behavior

Currently, the padding on an IBorderInfoProvider is not used to calculate the numbers for the border shape and the border background. A quick attempt found some differences between WinUI and Uno (at least skia) when Padding is added. This should be investigated after https://github.com/unoplatform/uno/pull/16562 merges

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

MartinZikmund commented 1 month ago

This also should take BackgroundSizing property into account

Youssef1313 commented 1 month ago

I thought padding is only considered during measure/arrange and shouldn't have any impact elsewhere 😕

Youssef1313 commented 4 weeks ago

@ramezgerges Can you extend the issue for exact scenario that's currently broken?

ramezgerges commented 3 weeks ago

The BorderVisualClipping sample used to do some weird stuff if you added a Padding to the elements, but I'm testing it now and it seems to be... fine? I will close for now until I find an actual problem.

unoplatform / uno