search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.48k stars 690 forks source link

fix: Don't rewrite the target frameworks list on a class library #16710

Closed jeromelaban closed 2 weeks ago

jeromelaban commented 2 weeks ago

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno/issues/16692

PR Type

What kind of change does this PR introduce?

What is the new behavior?

Don't rewrite target frameworks for libraries, it's not required and causes invalid TFMs values.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16710/index.html

unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16710/index.html

jeromelaban commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 2 pipeline(s).
unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16710/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16710/index.html

agneszitte commented 2 weeks ago

@jeromelaban this needs to be backported right?

jeromelaban commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago
Azure Pipelines successfully started running 2 pipeline(s).
unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16710/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16710/index.html

nventive-devops commented 2 weeks ago

The build 125055 found UI Test snapshots differences: android-28-net7: 22, android-28-net7-Snap: 43, ios: 3, ios-Snap: 88, skia-gtk-screenshots: 57, skia-linux-screenshots: 70, skia-windows-screenshots: 45, wasm: 709, wasm-automated-net7.0-UWP-Default-automated: 122, wasm-automated-net7.0-UWP-RuntimeTests-0: 1, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net7`: **22** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `RadioButtons_Disable_Validation_UITests_Shared_Windows_UI_Xaml_Controls_RadioButtonTests_RadioButton_IsEnabled_Automated` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `When_InListView_after_scroll` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `WebView_NavigateToLongString_AfterSuccess` - `DatePicker_PickerFlyout_PlacementstopLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement` - `Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic` - `NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample` - `When_InScrollViewer_after_scroll` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage`
* `android-28-net7-Snap`: **43** changed over 1059
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic` - `Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage` - `Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground` - `MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage` - `TextBox_PasswordBox_InputScope_NumericPin_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_InputScope_NumericPin` - `TextBox_PasswordBox_Simple_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Simple` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal` - `ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading` - `Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius` - `WebView_WebView_ChromeClient_Uno_UI_Samples_Content_UITests_WebView_WebView_ChromeClient` - `WebView_WebView_JavascriptInvoke_Uno_UI_Samples_Content_UITests_WebView_WebView_JavascriptInvoke` - `WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri` - `Border_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadius` - `TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage` - `WebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync` - `Buttons_RadioButton_Multiple_Unnamed_Groups_Uno_UI_Samples_Content_UITests_ButtonTestsControl_RadioButton_Multiple_Unnamed_Groups` - `Windows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTests`
* `ios`: **3** changed over 269
🚨🚨 Comparison Details (first 20) 🚨🚨 - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220`
* `ios-Snap`: **88** changed over 1050
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Path_PathTime_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathTime` - `Path_PathVerticalOffsetAdjustable_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathVerticalOffsetAdjustable` - `Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl` - `NavigationView_MUXControlsTestApp_PaneLayoutTestPage_MUXControlsTestApp_PaneLayoutTestPage` - `NavigationView_NavigationViewSample_SamplesApp_Samples_NavigationViewSample_NavigationViewSample` - `NavigationView_NavigationView_BasicNavigation_SamplesApp_Samples_Windows_UI_Xaml_Controls_NavigationViewTests_NavigationView_BasicNavigation` - `NavigationView_NavigationView_TopNavigation_UITests_Shared_Windows_UI_Xaml_Controls_NavigationViewTests_NavigationView_TopNavigation` - `Path_PathCircularInsideEllipse_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathCircularInsideEllipse` - `Path_PathResize_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathResizeTest` - `Path_PathScrollViewer_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_PathScrollViewer` - `Path_StrokeThickness10_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StrokeThickness10` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `Path_Path_Arc_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Arc` - `Path_Path_CircularWheel_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_CircularWheel` - `Path_Path_Dynamic_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic` - `Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage` - `NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample` - `Path_Path_Geometry_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometry` - `Path_StretchNoneHorizontalAlignmentRight_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StretchNoneHorizontalAlignmentRight` - `Path_StretchNone_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StretchNone`
* `skia-gtk-screenshots`: **57** changed over 2190
🚨🚨 Comparison Details (first 20) 🚨🚨 - `FadeInOutThemeAnimationPage.png` - `FadeInOutThemeAnimationPage.png-dark` - `ListView_With_ListViews_Count_Measure.png-dark` - `ListView_With_ListViews_Count_Measure.png` - `SvgImageSource_FromStream.png-dark` - `SvgImageSource_FromStream.png` - `Mini player.png-dark` - `Mini player.png` - `PhaseBinding_StartOne.png-dark` - `PhaseBinding_StartOne.png` - `WinUIProgressBarSimple.png-dark` - `WinUIProgressBarSimple.png` - `BorderImageBrush.png-dark` - `BorderImageBrush.png` - `ImageBrush_Formats.png-dark` - `ImageBrush_Formats.png` - `UIElement_ContextFlyout.png-dark` - `UIElement_ContextFlyout.png` - `Vector3KeyFrameAnimationSample.png-dark` - `Vector3KeyFrameAnimationSample.png`
* `skia-linux-screenshots`: **70** changed over 2190
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageWithLateSourceUniformToFill.png-dark` - `ImageWithLateSourceUniformToFill.png` - `BorderImageBrush.png` - `BorderImageBrushRelativeTransform.png-dark` - `ImageBrush_UniformToFill.png-dark` - `ImageBrush_UniformToFill.png` - `BorderImageBrushRelativeTransform.png` - `ImageBrush_Formats.png-dark` - `ImageBrush_Formats.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `CompositionNineGridBrush_Source_Changes.png-dark` - `CompositionNineGridBrush_Source_Changes.png` - `FluentStyle_NavigationViewSample.png-dark` - `FluentStyle_NavigationViewSample.png` - `ImageBrushStretch2.png-dark` - `ImageBrushStretch2.png` - `BorderImageBrush.png-dark`
* `skia-windows-screenshots`: **45** changed over 2190
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Ellipse.png-dark` - `Ellipse.png` - `FluentStyle_NavigationViewSample.png-dark` - `FluentStyle_NavigationViewSample.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `ImageBrush_Formats.png-dark` - `ImageBrush_Formats.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `DoubleImageBrushInList.png-dark` - `DoubleImageBrushInList.png` - `ImageSourceUrlMsAppDataScheme.png-dark` - `ImageSourceUrlMsAppDataScheme.png` - `Image_Stretch_None_ScrollViewer.png-dark` - `Image_Stretch_None_ScrollViewer.png` - `Mini player.png-dark` - `Mini player.png`
* `wasm`: **709** changed over 1040
🚨🚨 Comparison Details (first 20) 🚨🚨 - `GenericApp.Views.Content.UITests.ImageBrushTestControl.ImageBrush_UniformToFill` - `MUXControlsTestApp.HierarchicalNavigationViewMarkup` - `MUXControlsTestApp.NavigationViewAnimationPage` - `MUXControlsTestApp.RefreshVisualizerPage` - `MUXControlsTestApp.SwipeControlPage2` - `SamplesApp.Samples.RoutedEvents.RoutedEventsPage` - `SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_Off_Centre_RotateTransform` - `SamplesApp.Windows_UI_Xaml_Controls.ContentControlNoTemplateNoContent` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderImage` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderUpdate` - `SamplesApp.Windows_UI_Xaml_Controls.ToggleSwitchControl.ToggleSwitch_Custom` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchNone` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchNoneHorizontalAlignmentRight` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Test3` - `SamplesApp.Windows_UI_Xaml_Shapes.PolygonPage` - `UITests.Microsoft_UI_Xaml_Controls.RadioButtonsTests.RadioButtonsFocusPage` - `UITests.Shared.Microsoft_UI_Xaml_Controls.RadioMenuFlyoutItemTests.RadioMenuFlyoutItemPage` - `UITests.Shared.Microsoft_UI_Xaml_Controls.TreeViewTests.TreeViewPage` - `UITests.Shared.Windows_UI_Xaml_Controls.ContentDialogTests.ContentDialog_Simple` - `UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_Attached`
* `wasm-automated-net7.0-UWP-Default-automated`: **122** changed over 1958
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_StrokeThickness_MyLine_0_StrokeThickness` - `FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_FocusManager_-_LostFocus_-_ListViewItem_-_2_-_Click_outside` - `FocusManager_GetFocusedElement_ListViewItem_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `FocusManager_GetFocusedElement_ListViewItem_Validation_FocusManager_-_GetFocusedElement_-_ListViewItem_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_TextBlock_Validation_FocusManager_-_GetFocusedElement_-_TextBlock_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_TextBlock_Validation_FocusManager_-_GetFocusedElement_-_TextBlock_-_2_-_After_Selection` - `FocusManager_GetFocusedElement_TextBlock_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `FocusManager_GetFocusedElement_TextBoxMultiLine_LostFocus_Validation_FocusManager_-_LostFocus_-_TextBoxMultiLine_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_ComboBoxItem_Validation_FocusManager_-_GetFocusedElement_-_ComboBoxItem_-_2_-_After_Selection` - `FocusManager_GetFocusedElement_ComboBoxItem_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_2_-_Click_outside` - `Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `FocusManager_GetFocusedElement_ComboBox_Validation_FocusManager_-_GetFocusedElement_-_ComboBox_-_1_-_Initial_State` - `FocusManager_GetFocusedElement_ComboBox_Validation_FocusManager_-_GetFocusedElement_-_ComboBox_-_2_-_After_Selection` - `FocusManager_GetFocusedElement_ComboBox_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `FocusManager_GetFocusedElement_ToggleButton_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `Focus_GetFocus_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **1** changed over 1
🚨🚨 Comparison Details (first 20) 🚨🚨 - `RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage`
* `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **0** changed over 1
jeromelaban commented 2 weeks ago

@mergifyio backport release/stable/5.2

mergify[bot] commented 2 weeks ago

backport release/stable/5.2

✅ Backports have been created

* [#16733 fix: Don't rewrite the target frameworks list on a class library (backport #16710)](https://github.com/unoplatform/uno/pull/16733) has been created for branch `release/stable/5.2`