search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.51k stars 690 forks source link

fix: Add `ApplicationId` to allow for VS Automatic Provisioning of Samples app #16760

Closed MartinZikmund closed 3 weeks ago

MartinZikmund commented 4 weeks ago

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

VS Automatic provisioning for iOS fails when <ApplicationId> is missing

What is the new behavior?

Added

PR Checklist

Please check if your PR fulfills the following requirements:

unodevops commented 4 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16760/index.html

unodevops commented 4 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16760/index.html

nventive-devops commented 4 weeks ago

The build 125409 found UI Test snapshots differences: android-28-net7: 18, android-28-net7-Snap: 29, ios: 4, ios-Snap: 32, skia-gtk-screenshots: 35, skia-linux-screenshots: 14, skia-windows-screenshots: 26, wasm: 315, wasm-automated-net7.0-UWP-Default-automated: 26, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net7`: **18** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage` - `When_InListView_after_scroll` - `When_InScrollViewer_after_scroll` - `PopupWithOverlay_After` - `WebView_NavigateToLongString_AfterSuccess` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220`
* `android-28-net7-Snap`: **29** changed over 1061
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage` - `MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage` - `Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage` - `TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage` - `ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage` - `NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page` - `TextBox_PasswordBox_AutoFill_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_AutoFill` - `TextBox_PasswordBox_Header_PlaceholderText_Uno_UI_Samples_Content_UITests_TextBoxControl_PasswordBox_Header_PlaceholderText` - `MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage` - `Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics` - `Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage` - `Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage` - `TextBox_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_Width_Affects_Delete_Button_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_Width_Affects_Delete_Button` - `Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `TextBox_Input_With_PlaceholderText_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_With_PlaceholderText`
* `ios`: **4** changed over 269
🚨🚨 Comparison Details (first 20) 🚨🚨 - `TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings` - `Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220`
* `ios-Snap`: **32** changed over 1052
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren` - `ListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector` - `Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch` - `Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList` - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions` - `Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical` - `Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl` - `ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image` - `TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal` - `Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset` - `ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample` - `ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage` - `WebView_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title` - `WebView_WebView2_Javascript_AlertConfirmPrompt_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2ControlJavaScriptAlertConfirmPrompt` - `Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping` - `Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller` - `Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider` - `WebView_WebView_NavigateToUri_Uno_UI_Samples_Content_UITests_WebView_WebView_NavigateToUri`
* `skia-gtk-screenshots`: **35** changed over 2196
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BorderImageBrush.png` - `BorderImageBrush.png-dark` - `TransformToVisual_Simple.png-dark` - `TransformToVisual_Simple.png` - `BorderImageBrushRelativeTransform.png-dark` - `Path_Geometries.png-dark` - `Path_Geometries.png` - `ImageBrushAlignmentXY2.png` - `PasswordBox_AutoFill.png-dark` - `PasswordBox_AutoFill.png` - `Uniform100x100.png-dark` - `Uniform100x100.png` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png` - `BorderImageBrushRelativeTransform.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `ImageBrushChangingCornerRadius.png` - `ImageBrushStretch2.png` - `ImageBrushAlignmentXY2.png-dark`
* `skia-linux-screenshots`: **14** changed over 2196
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ImageBrushStretch2.png-dark` - `ImageBrushStretch2.png` - `ImageBrush_StreamSource.png-dark` - `ImageBrush_StreamSource.png` - `Image_Stretch_None.png-dark` - `Image_Stretch_None.png` - `Image_Stretch_None_ScrollViewer.png-dark` - `Image_Stretch_None_ScrollViewer.png` - `Mini player.png-dark` - `Mini player.png` - `Using .ogg.png-dark` - `Using .ogg.png` - `TransformToVisual_Translate2d.png-dark` - `TransformToVisual_Translate2d.png`
* `skia-windows-screenshots`: **26** changed over 2196
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BorderImageBrush.png-dark` - `BorderImageBrush.png` - `BorderImageBrushRelativeTransform.png-dark` - `ImageSourceUrlMsAppDataScheme.png-dark` - `ImageSourceUrlMsAppDataScheme.png` - `ImageBrushInList.png-dark` - `ImageBrushInList.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `BorderImageBrushRelativeTransform.png` - `ColorPickerSample.png-dark` - `ColorPickerSample.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `Mini player.png-dark` - `Mini player.png`
* `wasm`: **315** changed over 1042
🚨🚨 Comparison Details (first 20) 🚨🚨 - `MUXControlsTestApp.NavigationViewMenuItemStretchPage` - `MUXControlsTestApp.RefreshVisualizerPage` - `SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_Mailto` - `SamplesApp.Samples.RoutedEvents.RoutedEventsPage` - `SamplesApp.Samples.UnitTests.HttpUnitTests` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_WithFlipView` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_WithScrollViewer` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathVerticalOffsetII` - `UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewItemsSourceTests` - `UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage` - `UITests.Shared.Windows_UI_Input.GestureRecognizerTests.TappedTest` - `UITests.Shared.Windows_UI_Xaml_Controls.MenuFlyoutTests.UIElement_ContextFlyout` - `UITests.Shared.Windows_UI_Xaml_Controls.PasswordBoxTests.PasswordBoxPage` - `UITests.Toolkit.ElevatedViewTests` - `UITests.Windows_UI_Xaml.UIElementTests.UIElement_Alignments` - `UITests.Windows_UI_Xaml.UIElementTests.UIElement_ArrangeOverride_Alignment` - `UITests.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_LayoutAlignment` - `MUXControlsTestApp.NavigationViewStretchPage` - `MUXControlsTestApp.RadialGradientBrushPage` - `nVentive.Umbrella.Views.UI.Samples.Content.UITests.ButtonTestsControl.Hyperlink_Disabled`
* `wasm-automated-net7.0-UWP-Default-automated`: **26** changed over 1960
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Check_ListView_Swallows_Measure_after_scroll` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries` - `Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry` - `Performance_Dopes_UITests_Windows_UI_Xaml_Performance_Performance_Dopes` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated` - `ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPage` - `TextBlock_TextBlock_LineHeight_TextTrimming_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_TextTrimming` - `When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal`
* `wasm-automated-net7.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net7.0-WinUI-RuntimeTests-2`: **0** changed over 1