[Sdk] RuntimeTests require WINDOWS_WINUI be defined - Githubissues

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.

https://platform.uno

Apache License 2.0

8.76k stars 705 forks source link

[Sdk] RuntimeTests require WINDOWS_WINUI be defined #17375

Open dansiegel opened 2 months ago

dansiegel commented 2 months ago

Current behavior

When adding runtime tests to a Single Project we get a build error on WinUI because WINDOWS_WINUI is not defined

Expected behavior

WINDOWS_WINUI should be defined in the SDK

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

Windows (WinAppSDK)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Youssef1313 commented 2 months ago

If this symbol is really very specific to runtime tests engine package, I think the package itself is responsible for defining it. If we need to make it very global, I think it could then be set by Uno.WinUI instead of the SDK to account for usages in non-Uno.Sdk projects. My view of this is it's not really specific to SDK.