search

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.77k stars 706 forks source link

[Sdk] Requires Skottie for Desktop with ThemeService and MediaElement #17377

Open dansiegel opened 2 months ago

dansiegel commented 2 months ago

Current behavior

With a project using the following UnoFeatures plus the Runtime Tests we end up in a situation where we have a build failure for the Desktop Target. The target requires an additional package reference for SkiaSharp.Skottie.

Expected behavior

This should be done implicitly by the SDK.

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

jeromelaban commented 1 month ago

@dansiegel what's the link between themeservice and mediaelement with Lottie?

dansiegel commented 1 month ago

@dansiegel what's the link between themeservice and mediaelement with Lottie?

That's a fantastic question. The issue was discovered on the C# Markup Runtime tests... so this issue was to remember to investigate and resolve it.