unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.77k stars 706 forks source link

[Gallery][TextBox] Placeholder Text not in center #17606

Open jhanvi03 opened 1 month ago

jhanvi03 commented 1 month ago

Current behavior

The placeholder in the textbox are not in center for Fluent.

Expected behavior

the placeholder text should be vertically centered.

How to reproduce it (as minimally and precisely as possible)

Steps to reproduce:

  1. Open Gallery on any of the browser
  2. Navigate to any Fluent TextBox
  3. Observe the Placeholder text in the TextBox

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

ArchieCoder commented 1 month ago

@jhanvi03 Check https://github.com/unoplatform/uno/issues/16931#event-13474011487 along with the upcoming fix https://github.com/unoplatform/uno/issues/3954

agneszitte commented 2 weeks ago

@jhanvi03 this will need to be re-tested with the latest Gallery canary please

jhanvi03 commented 1 week ago

Tested with latest Gallery canary and Placeholders are not align in centre for all: Overview->fluent Theming ->Lightweight Styling -> Fluent UI Components -> textbox -> Fluent image image image

agneszitte commented 1 week ago

@Youssef1313 if you can take a look at this issue for WebAssembly, please. Here @jhanvi03 tested latest gallery canary that uses latest Uno.Sdk 5.4.0-dev.234

Youssef1313 commented 1 week ago

@agneszitte In WinUI, TextBox text is top-aligned, not centered. If for Material specifically it's needed to be centered, maybe some adjustments to the Material template will be needed, I think?