chore: Avoid duplicated logs and prevent error bubbling

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!

https://platform.uno

Apache License 2.0

9.06k stars 735 forks source link

chore: Avoid duplicated logs and prevent error bubbling #18746

Closed dr1rrb closed 2 weeks ago

dr1rrb commented 2 weeks ago

Chore

Avoid duplicated logs and prevent error bubbling

What is the current behavior?

Errors might logged twice
Once logged, error are re-thrown driving to unknown behavior

What is the new behavior?

Errors logged only once
Once logged, errors are discarded

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Validated PR Screenshots Compare Test Run results.
[x] Contains NO breaking changes
[ ] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
[x] Commits must be following the Conventional Commits specification.

jeromelaban commented 2 weeks ago

@mergifyio backport release/stable/5.5

mergify[bot] commented 2 weeks ago

backport release/stable/5.5

✅ Backports have been created

* [#18756 chore: Avoid duplicated logs and prevent error bubbling (backport #18746)](https://github.com/unoplatform/uno/pull/18756) has been created for branch `release/stable/5.5` but encountered conflicts

unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18746/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18746/index.html

jeromelaban commented 2 weeks ago

/azp run

azure-pipelines[bot] commented 2 weeks ago

Azure Pipelines successfully started running 2 pipeline(s).

unodevops commented 2 weeks ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18746/index.html

unodevops commented 2 weeks ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18746/index.html