unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.03k stars 733 forks source link

TimePicker ClockIdentifier does not use correct default value #18834

Open mikernet opened 3 days ago

mikernet commented 3 days ago

Current behavior

ClockIdentifier defaults to "12HourClock" on WinUI, but "24HourClock" on Uno.

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

Add a TimePicker anywhere and notice that it defaults to a 24 hour clock.

Workaround

Set ClockIdentifier to 12HourClock explicitly.

Works on UWP/WinUI

None

Environment

Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

5.5.43

Affected platforms

iOS and Android was tested, could affect others.

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

MartinZikmund commented 2 days ago

@mikernet I don't see this behavior - see Playground sample

image

Which targets do you observe this on? Can you provide some repro please?

MartinZikmund commented 2 days ago

It could be the culture setting influencing this as well, which language are you using?

mikernet commented 2 days ago

I indicated in the issue that I'm seeing it on Android and iOS. Both are set to cultures with 12h time formats (English/Canada).

MartinZikmund commented 1 day ago

I see, those platforms are utilizing the native controls, could be the reason potentially. I guess you see the issue only in the picker flyout itself, correct? When closed, the format is as expected?

mikernet commented 1 day ago

I see it in all cases - UseNative set to true, set to false, and in both the picker itself and the flyout/native picker.