search

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.03k stars 733 forks source link

fix(net9): Allow for builds to happen even if a RID is explicitly set #18853

Closed jeromelaban closed 1 day ago

jeromelaban commented 2 days ago

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno/issues/18796

PR Type

What kind of change does this PR introduce?

What is the new behavior?

Ensures that nuget targets can still be called when a RID is not matching wasm.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

unodevops commented 2 days ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18853/index.html

unodevops commented 2 days ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18853/index.html

unodevops commented 2 days ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18853/index.html

unodevops commented 2 days ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18853/index.html

unodevops commented 2 days ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18853/index.html

unodevops commented 2 days ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18853/index.html

nventive-devops commented 1 day ago

The build 147852 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 38, ios: 6, ios-Snap: 50, skia-gtk-screenshots: 72, skia-linux-screenshots: 67, skia-windows-screenshots: 70, wasm: 440, wasm-automated-net9.0-UWP-Default-automated: 22, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net8`: **23** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Button_Events_UITests_Shared_Windows_UI_Xaml_Controls_Button_Button_Events` - `CheckBox_DoubleTapValidation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `ContentDialog_Simple_NotLightDismissible_UITests_Shared_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_Simple` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `TextBox_Foreground_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Foreground` - `TextBox_IsReadOnly_AcceptsReturn_Test_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_IsReadOnly_AcceptsReturn` - `WebView_NavigateToLongString_AfterSuccess` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `FocusManager_GetFocusedElement_Rectangle_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer`
* `android-28-net8-Snap`: **38** changed over 1068
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream` - `Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Clipping_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_two_grids_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_two_grids` - `Clipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping_SamplesApp_Windows_UI_Xaml_Clipping_UIElementClipping` - `Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout` - `Animations_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage_UITests_Windows_UI_Xaml_Media_Animation_FadeInOutThemeAnimationPage` - `MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage` - `Clipping_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_Two_Canvas_in_Grid_SamplesApp_Windows_UI_Xaml_Clipping_Transform_Ellipse_in_Two_Canvas_in_Grid` - `NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage` - `Application_UITests_Windows_UI_Xaml_ApplicationTests_Given_Application_UITests_Windows_UI_Xaml_ApplicationTests_Given_Application` - `Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset` - `NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage` - `NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage` - `SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2` - `Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY` - `WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic`
* `ios`: **6** changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings` - `When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220`
* `ios-Snap`: **50** changed over 1059
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill` - `Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform` - `Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate` - `Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList` - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground` - `Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats` - `ListView_ListView_WithScrollViewer_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_WithScrollViewer` - `NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage` - `NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page` - `Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch` - `Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform` - `Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill` - `Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback_UITests_Windows_UI_Xaml_Media_BrushesTests_RevealBrush_Fallback` - `ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox` - `TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run` - `GridView_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped`
* `skia-gtk-screenshots`: **72** changed over 2228
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ButtonClippingTestsControl.png` - `Buttons.png-dark` - `DisplayInformation.png-dark` - `Buttons.png` - `ClipboardTests.png-dark` - `ImageBrush_SameWithDelay.png-dark` - `ImageBrush_SameWithDelay.png` - `BorderImageBrushRelativeTransform.png-dark` - `DisplayInformation.png` - `Popup_HVAlignments.png-dark` - `Popup_HVAlignments.png` - `BorderImageBrushRelativeTransform.png` - `ToggleButton_IsEnabled_Automated.png-dark` - `ToggleButton_IsEnabled_Automated.png` - `CalendarView_Theming.png-dark` - `ImageBrushAlignmentXY2.png-dark` - `ImageBrushAlignmentXY2.png` - `Uniform100x100.png-dark` - `Uniform100x100.png` - `UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark`
* `skia-linux-screenshots`: **67** changed over 2228
🚨🚨 Comparison Details (first 20) 🚨🚨 - `DisplayInformation.png-dark` - `DisplayInformation.png` - `Gamepad_CurrentReading.png-dark` - `Gamepad_CurrentReading.png` - `BorderImageBrush.png` - `CalendarView_Theming.png-dark` - `ContentPresenter_NativeEmbedding.png-dark` - `ContentPresenter_NativeEmbedding.png` - `ImageIconPage.png-dark` - `ImageIconPage.png` - `BorderImageBrushRelativeTransform.png-dark` - `BorderImageBrushRelativeTransform.png` - `Buttons.png-dark` - `Buttons.png` - `Focus_FocusVisual_Properties.png-dark` - `Focus_FocusVisual_Properties.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png`
* `skia-windows-screenshots`: **70** changed over 2228
🚨🚨 Comparison Details (first 20) 🚨🚨 - `BorderImageBrushRelativeTransform.png` - `ButtonClippingTestsControl.png-dark` - `ButtonClippingTestsControl.png` - `Buttons.png-dark` - `Focus_FocusVisual_Properties.png-dark` - `Focus_FocusVisual_Properties.png` - `Gamepad_CurrentReading.png-dark` - `Examples.png` - `ImagesInlineInFlipView.png-dark` - `ImagesInlineInFlipView.png` - `BorderImageBrush.png-dark` - `ExpanderColorValidationPage.png-dark` - `ExpanderColorValidationPage.png` - `BorderImageBrushRelativeTransform.png-dark` - `BorderImageBrush.png` - `Buttons.png` - `DisplayInformation.png-dark` - `DisplayInformation.png` - `ImageBrushAlignmentXY2.png-dark` - `ImageBrushAlignmentXY2.png`
* `wasm`: **440** changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨 - `GenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionMode` - `SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_Static` - `SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_WithHeaders` - `SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_RotateTransform` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedChanging` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedEmpty` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewResizable` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Test3` - `UITests.Shared.Windows_ApplicationModel.Email.EmailManagerTests` - `UITests.Shared.Windows_Devices.Midi.MidiDeviceOutputTests` - `UITests.Shared.Windows_UI_Xaml_Automation.AutomationProperties_Name` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_With_ListViews_Count_Measure` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView_Header_DataContextChanging` - `UITests.Shared.Windows_UI_Xaml_Controls.ListView_OwnContainer_Virtualized` - `UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Minimal` - `UITests.Shared.Windows_UI_Xaml_Controls.WebView.WebView_Animated_Opacity` - `UITests.Windows_UI_Input.PointersTests.HitTest_LightDismiss` - `UITests.Windows_UI_Xaml.xLoadTests.xLoad_Test_For_Leak` - `UITests.Windows_UI_Xaml_Controls.ItemsControl.ItemsControl_ReplaceItem` - `UITests.Windows_UI_Xaml_Controls.ListView.ListViewItem_Click_Focus`
* `wasm-automated-net9.0-UWP-Default-automated`: **22** changed over 1948
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_StrokeThickness_MyRect` - `Default_StrokeThickness_MyRect_0_StrokeThickness` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Default_StrokeThickness_MyLine` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension` - `Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource` - `Dismiss_MenuFlyout_fileMenu` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `Default_StrokeThickness_MyPolygon` - `Default_StrokeThickness_MyPolygon_0_StrokeThickness` - `When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features` - `Windows_Devices_Midi_DeviceEnumeration_UITests_Shared_Windows_Devices_Midi_MidiDeviceEnumerationTests` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers`
* `wasm-automated-net9.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net9.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net9.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-2`: **0** changed over 1
jeromelaban commented 1 day ago

@mergifyio backport release/stable/5.5

mergify[bot] commented 1 day ago

backport release/stable/5.5

✅ Backports have been created

* [#18864 fix(net9): Allow for builds to happen even if a RID is explicitly set (backport #18853)](https://github.com/unoplatform/uno/pull/18864) has been created for branch `release/stable/5.5`