unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.03k stars 733 forks source link

fix(webview2): Adjust target platform selection for windows builds #18872

Closed jeromelaban closed 15 hours ago

jeromelaban commented 1 day ago

GitHub Issue (If applicable): fixes https://github.com/unoplatform/uno/issues/18552

PR Type

What kind of change does this PR introduce?

What is the new behavior?

Properly set PlatformTarget when using AnyCPU

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

unodevops commented 1 day ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18872/index.html

unodevops commented 1 day ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18872/index.html

nventive-devops commented 1 day ago

The build 147961 found UI Test snapshots differences: android-28-net8: 21, android-28-net8-Snap: 37, ios: 8, ios-Snap: 41, skia-gtk-screenshots: 53, skia-linux-screenshots: 68, skia-windows-screenshots: 55, wasm: 410, wasm-automated-net9.0-UWP-Default-automated: 25, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details * `android-28-net8`: **21** changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨 - `ContentDialog_Simple_NotLightDismissible_UITests_Shared_Windows_UI_Xaml_Controls_ContentDialogTests_ContentDialog_Simple` - `DatePicker_PickerFlyout_PlacementsbottomLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement` - `Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75` - `Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25` - `FocusManager_GetFocusedElement_Rectangle_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `WebView_NavigateToAnchor_Initial` - `WebView_NavigateToAnchor_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage` - `When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer` - `When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch` - `Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50` - `When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers`
* `android-28-net8-Snap`: **37** changed over 1068
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Buttons_Buttons_Native_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native` - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2` - `TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage` - `Animations_DoubleAnimationUsingKeyFrames_TranslateX_GenericApp_Views_Content_UITests_Animations_DoubleAnimationUsingKeyFrames_TranslateX` - `Buttons_CheckBox_Button_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_Button` - `NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage` - `NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage` - `Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid` - `NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page` - `Animations_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty_UITests_Shared_Windows_UI_Xaml_Media_Animation_SetTargetProperty` - `Border_Border_Simple_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Opacity` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY` - `Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage` - `WebView_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title` - `Animations_DoubleAnimationTestsControl_Uno_UI_Samples_Content_UITests_DoubleAnimationTestsControl` - `Border_Border_Simple_with_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Uniform_Thickness`
* `ios`: **8** changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨 - `When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage` - `When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers` - `TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings` - `Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure` - `Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes` - `ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220` - `ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220`
* `ios-Snap`: **41** changed over 1059
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Default_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_CornerRadius_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_CornerRadius` - `Flyouts_MenuFlyoutItem_Click_UITests_Shared_Windows_UI_Xaml_Controls_MenuFlyoutTests_MenuFlyoutItem_Click` - `ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image` - `TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run` - `Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush` - `ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage` - `GridView_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped_GenericApp_Views_Samples_Shared_Content_UITests_GridViewGrouped` - `Image_EmptyImageFixedWidth_Uno_UI_Samples_UITests_ImageTestsControl_EmptyImageFixedWidth` - `Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_Dismissal` - `NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage` - `NavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPage` - `Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush` - `Focus_FocusManagerTest_Uno_UI_Samples_Content_UITests_FocusTests_FocusManagerTest` - `Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage` - `Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren` - `TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel` - `ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample` - `SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2` - `Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY` - `WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties`
* `skia-gtk-screenshots`: **53** changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Gamepad_Enumeration.png-dark` - `UIElement_MeasureDirtyPath.png-dark` - `UIElement_MeasureDirtyPath.png` - `UIElement_ContextFlyout.png-dark` - `UIElement_ContextFlyout.png` - `ClipboardTests.png-dark` - `ClipboardTests.png` - `WinUIExpanderPage.png-dark` - `WinUIProgressBarSimple.png-dark` - `WinUIProgressBarSimple.png` - `Gamepad_Enumeration.png` - `NetworkInformation.png-dark` - `NetworkInformation.png` - `Ellipse.png-dark` - `Ellipse.png` - `Focus_FocusVisual_Properties.png-dark` - `CalendarView_Theming.png-dark` - `Examples.png` - `RepeatButton_Automated.png-dark` - `RepeatButton_Automated.png`
* `skia-linux-screenshots`: **68** changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨 - `DisplayInformation.png-dark` - `DisplayInformation.png` - `Gamepad_CurrentReading.png-dark` - `Gamepad_CurrentReading.png` - `Gamepad_Enumeration.png-dark` - `Gamepad_Enumeration.png` - `ButtonClippingTestsControl.png-dark` - `ClipboardTests.png` - `ImageInStackPanel.png-dark` - `ImageInStackPanel.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `DropDownButtonPage.png-dark` - `Focus_FocusVisual_Properties.png-dark` - `ImageBrushInList.png-dark` - `ImageBrushInList.png` - `ClipboardTests.png-dark` - `CalendarView_Theming.png-dark` - `ContentPresenter_NativeEmbedding.png-dark` - `ContentPresenter_NativeEmbedding.png`
* `skia-windows-screenshots`: **55** changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨 - `DragDrop_TestPage.png-dark` - `DragDrop_TestPage.png` - `ClipboardTests.png-dark` - `ClipboardTests.png` - `ButtonClippingTestsControl.png` - `DisplayInformation.png-dark` - `DisplayInformation.png` - `Gamepad_CurrentReading.png-dark` - `Gamepad_Enumeration.png-dark` - `Gamepad_Enumeration.png` - `Image_UseTargetSize.png-dark` - `Image_UseTargetSize.png` - `Buttons.png` - `ButtonClippingTestsControl.png-dark` - `DropDownButtonPage.png-dark` - `DropDownButtonPage.png` - `Examples.png` - `ContentPresenter_NativeEmbedding.png-dark` - `ContentPresenter_NativeEmbedding.png` - `LargeImageList.png-dark`
* `wasm`: **410** changed over 1045
🚨🚨 Comparison Details (first 20) 🚨🚨 - `SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected` - `SamplesApp.Windows_UI_Xaml_Controls.ContentControlNoTemplateNoContent` - `SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedLarge` - `SamplesApp.Windows_UI_Xaml_Controls.ToggleSwitchControl.Native_ToggleSwitch_IsOn` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathResizeTest` - `SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathStretchInsideContainer` - `UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage` - `UITests.Shared.Windows_UI_Xaml.UIElementTests.UIElement_Native_Child` - `UITests.Shared.Windows_UI_Xaml.VisualStateTests.VisualState_Forever_Events` - `UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_IsReadOnly_AcceptsReturn` - `UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_Selection` - `UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_TextChanged` - `UITests.Windows_UI_Input.PointersTests.HitTest_Shapes` - `UITests.Windows_UI_Xaml_Controls.Repeater.ItemsRepeater_Nested` - `UITests.Windows_UI_Xaml_Controls.Repeater.StackLayout_Simple` - `UITests.Windows_UI_Xaml_Controls.TextBox.TextBox_Margin` - `UITests.Windows_UI_Xaml_Controls.TextBox.TextBox_SelectionHighlightColor` - `UITests.Windows_UI_Xaml_Controls.TextBox.TextBox_Visibility` - `Benchmarks.Shared.Controls.BenchmarkDotNetTestsPage` - `GenericApp.Views.Content.UITests.ContentControlTestsControl.ContentControl_UnsetContent`
* `wasm-automated-net9.0-UWP-Default-automated`: **25** changed over 1948
🚨🚨 Comparison Details (first 20) 🚨🚨 - `Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name` - `Default_StrokeThickness_MyPolyline` - `Default_StrokeThickness_MyRect` - `Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage` - `Fonts_UITests_Windows_UI_Xaml_Media_FontTests_DynamicFont_UITests_Windows_UI_Xaml_Media_FontTests_DynamicFont` - `MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal` - `MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources` - `MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension` - `MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension` - `MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension` - `Default_StrokeThickness_MyPolygon` - `Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList` - `Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource` - `Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation` - `ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected` - `ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems` - `TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features` - `WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic` - `SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage`
* `wasm-automated-net9.0-UWP-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net9.0-UWP-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net9.0-UWP-RuntimeTests-2`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-Benchmarks-automated`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-0`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-1`: **0** changed over 1 * `wasm-automated-net9.0-WinUI-RuntimeTests-2`: **0** changed over 1