unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
9.03k stars 733 forks source link

fix(scrollviewer): fix scrollArgs.IsIntermediate on WASm #18883

Open ramezgerges opened 10 hours ago

ramezgerges commented 10 hours ago

GitHub Issue (If applicable): closes https://github.com/unoplatform/kahua-private/issues/230

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

dr1rrb commented 10 hours ago

That likely closes #16675 as well? cc @dr1rrb

For the rounding part yes, but there is still the question of if I programmatically request a scroll to 100px while the extent is only 50px tall. Does the _lastScrollToRequest is clamped before being assigned? What if the SV is resized during the async scrolling?

unodevops commented 10 hours ago

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18883/index.html

unodevops commented 8 hours ago

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18883/index.html