Update include-mainpage-xaml.md to updated xaml code

0xharkirat commented 1 day ago

This code is changed to the code generated using the template. Unless it is causing a build error on the old code.

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

Documentation content changes

<Page x:Class="Counter.MainPage"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      xmlns:local="using:Counter"
      Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">
  <StackPanel HorizontalAlignment="Center"
              VerticalAlignment="Center">
    <TextBlock AutomationProperties.AutomationId="HelloTextBlock"
               Text="Hello Uno Platform"
               HorizontalAlignment="Center" />
  </StackPanel>
</Page>

It is causing a build error like this:

What is the new behavior?

<Page x:Class="Counter.Presentation.MainPage"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      xmlns:local="using:Counter.Presentation"
      xmlns:uen="using:Uno.Extensions.Navigation.UI"
      xmlns:utu="using:Uno.Toolkit.UI"
      xmlns:um="using:Uno.Material"
      NavigationCacheMode="Required"
      Background="{ThemeResource BackgroundBrush}">
  <StackPanel HorizontalAlignment="Center"
              VerticalAlignment="Center">
    <TextBlock AutomationProperties.AutomationId="HelloTextBlock"
               Text="Hello Uno Platform"
               HorizontalAlignment="Center" />
  </StackPanel>
</Page>

PR Checklist

Please check if your PR fulfills the following requirements:

[ x] Docs have been added/updated which fit documentation template (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ x] Validated PR Screenshots Compare Test Run results.
[ x] Contains NO breaking changes
[ x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
[ x] Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

CLAassistant commented 1 day ago

All committers have signed the CLA.

unodevops commented 1 day ago

⚠️⚠️ The build 148755 has failed on Uno.UI - docs.

morning4coffe-dev commented 13 hours ago

Thank you for your contribution, @0xharkirat! Can you please reword (https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message) your commit to follow the Conventional commits standard? https://www.conventionalcommits.org/en/v1.0.0/ Thank you 😇

eriklimakc commented 10 hours ago

Hi @0xharkirat, I just created a new Uno app following the instructions in the Counter tutorial, and everything seems to be working correctly on my end. Could you double-check to ensure you used the blank preset rather than the recommended one?

For reference the MainPage xaml from a newly created app with the latest template, using the blank preset.

<Page x:Class="Counter.MainPage"
      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
      xmlns:local="using:Counter"
      Background="{ThemeResource ApplicationPageBackgroundThemeBrush}">
  <ScrollViewer>
    <Grid>
      <StackPanel
        HorizontalAlignment="Center"
        VerticalAlignment="Center">
        <TextBlock AutomationProperties.AutomationId="HelloTextBlock"
          Text="Hello Uno Platform!"
          HorizontalAlignment="Center" />
      </StackPanel>
    </Grid>
  </ScrollViewer>
</Page>

0xharkirat commented 5 hours ago

Oh, I was creating the app from the recommended preset (not the blank one). I think then this request is unnecessary. I can close this one.

agneszitte commented 4 hours ago

Oh, I was creating the app from the recommended preset (not the blank one). I think then this request is unnecessary. I can close this one.

Hi @0xharkirat, thank you for the confirmation. Yes, the Counter tutorial documentation mentions using the blank preset. I am closing this pull request

unoplatform / uno