Refactor shapes to remove legacy `ArbritaryShapeBase` on WASM

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!

https://platform.uno

Apache License 2.0

8.87k stars 716 forks source link

Refactor shapes to remove legacy `ArbritaryShapeBase` on WASM #2983

Closed BrianDT closed 1 year ago

BrianDT commented 4 years ago

⬇️ ⬇️ FOR MORE INFO, SCROLL TO COMMENTS BELOW ⬇️ ⬇️

Current behavior

In the example when an ellipse is resized by a visual state change trigger the parent stackpanel does not resize.

Expected behavior

WASM should beave the same as the UWP and Android builds.

How to reproduce it (as minimally and precisely as possible)

Reproduced in a sample project here: https://github.com/BrianDT/UnoGeometryIssues

Environment

Nuget Package: Uno.UI

Package Version(s): 2.2.0-dev.445

Affected platform(s):

[ ] iOS
[ ] Android
[ x] WebAssembly
[ ] WebAssembly renderers for Xamarin.Forms
[ ] macOS
[ ] Windows
[ ] Build tasks
[ ] Solution Templates

Visual Studio:

[ ] 2017 (version: )
[x ] 2019 (version: )
[ ] for Mac (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

jeromelaban commented 4 years ago

/cc @dr1rrb does it look familiar ?

dr1rrb commented 4 years ago

No idea for this one... To fix it, I would think that the easiest solution should be to multi-target what I did for iOS (and MacOS): https://github.com/unoplatform/uno/pull/2911

carldebilly commented 4 years ago

Investigations

I confirm the problem is present on WASM on both Uno v2.4.0 and v3.1.0-dev.389 (latest prerelease version)
I confirm the problem is not present on Android, both Uno v2.4.0 and v3.1.0-dev.389 (latest prerelease version)
I added a SKIA head to the sample app and the problem is NOT present on Skia using v3.1.0-dev.389 (latest prerelease version)

So I confirm it's a WASM-only bug and still present in latest version of Uno.

I also managed to isolate the problem into a self-contained XAML and I reproduced the problem on the Uno Playground. New updated version here.

carldebilly commented 4 years ago

Shapes on WASM are using a legacy ArbritraryShapeBase which should soon be refactored to use the new approach introduced by the PR #2997 on iOS and refactored for Skia in PR #3652.

I'll change the title of this issue to better reprensent the action item to resolved this issue, which is a refactoring.

BrianDT commented 3 years ago

Is there any workaround for this issue? As the issue is still present in 3.10.11 and it is delaying the replacement of an old Silverlight app.

sasakrsmanovic commented 3 years ago

Hello @BrianDT - would you kindly reach out to me at sasha@platform.uno I'd love to understand your migration project and help you through with it. Thanks!!

BrianDT commented 2 years ago

The sample has been updated to show that this is still an issue in 4.4.13. About time this was stored eh!

BrianDT commented 1 year ago

Confirmed as resolved in Uno.UI 4.5.9 The sample has been updated to validate this. The issue can now be closed