[WASM] `ScrollView` doesn't set its height correctly with `ItemsControl` inside - Githubissues

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!

https://platform.uno

Apache License 2.0

8.88k stars 717 forks source link

[WASM] `ScrollView` doesn't set its height correctly with `ItemsControl` inside #4034

Closed takla21 closed 8 months ago

takla21 commented 4 years ago

Current behavior

As you can see, we don't see the items inside the itemscontrol fully. wasm

Expected behavior

uwp

How to reproduce it (as minimally and precisely as possible)

Download ScrollViewerHeight.zip Deploy on WASM

Workaround

N/A

Environment

Nuget Package:

[x] Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
[ ] Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
[ ] Uno.SourceGenerationTasks
[ ] Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
[ ] Other:

Nuget Package Version(s): 3.1.0-dev.288

Affected platform(s):

[ ] iOS
[ ] Android
[x] WebAssembly
[ ] WebAssembly renderers for Xamarin.Forms
[ ] macOS
[ ] Skia
- [ ] WPF
- [ ] GTK (Linux)
- [ ] Tizen
[ ] Windows
[ ] Build tasks
[ ] Solution Templates

IDE:

[ ] Visual Studio 2017 (version: )
[x] Visual Studio 2019 (version: 16.6.2)
[ ] Visual Studio for Mac (version: )
[ ] Rider Windows (version: )
[ ] Rider macOS (version: )
[ ] Visual Studio Code (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

Youssef1313 commented 1 year ago

This is the behavior I'm seeing currently. @takla21 Can you confirm if there is still an issue here?

Youssef1313 commented 8 months ago

@takla21 Can you please confirm if this issue is fixed? Thanks!

takla21 commented 8 months ago

@Youssef1313 sorry for the huge delay. I tested it on the latest uno stable version 5.1.56 and it is indeed fixed now