unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
8.88k stars 717 forks source link

Uno.Material TimePicker MaterialTimePickerStyle with ClockIdentifier="24HourClock" error #4332

Closed iosub closed 8 months ago

iosub commented 3 years ago

Current behavior

in UWP <TimePicker ClockIdentifier="24HourClock" Style="{StaticResource MaterialTimePickerStyle}" /> Generates error Parameter Invalid

Expected behavior

it does work with ClockIdentifier="12HourClock"

How to reproduce it (as minimally and precisely as possible)

run the code above

Workaround

Environment

Nuget Package:

Nuget Package Version(s):

Affected platform(s):

IDE:

Relevant plugins:

Anything else we need to know?

francoistanguay commented 3 years ago

TimePicker isnt yet supported but we're planning to tackle it in an upcoming release.

MartinZikmund commented 3 years ago

@iosub Does the error occur in Uno Platform as well? If the error occurs in UWP only, then the best place to report it would be https://github.com/microsoft/microsoft-ui-xaml

GitHub
microsoft/microsoft-ui-xaml
Windows UI Library: the latest Windows 10 native controls and Fluent styles for your applications - microsoft/microsoft-ui-xaml
no-response[bot] commented 3 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. We don't monitor discussions on closed issues thus please open a new GitHub issue if you need the team to revisit this matter.

no-response[bot] commented 3 years ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. We don't monitor discussions on closed issues thus please open a new GitHub issue if you need the team to revisit this matter.

Youssef1313 commented 3 years ago

I can't reproduce any error here. Both 24HourClock and 12HourClock works fine for me.

MartinZikmund commented 8 months ago

I think this can be closed as Youssef checked.