CommandBar - Ellipsis Button Issues - Githubissues

unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.

https://platform.uno

Apache License 2.0

8.77k stars 707 forks source link

CommandBar - Ellipsis Button Issues #4395

Open LHuss opened 3 years ago

LHuss commented 3 years ago

Current behavior

Ellipsis is neither centered nor does it follow the AppBarEllipsisButtonForeground colors set in the resource dictionary.

Expected behavior

Ellipsis should be vertically centered and be the right color.

How to reproduce it (as minimally and precisely as possible)

Clone https://github.com/LHuss/UnoCommandBarIssues
Build & run project
Notice ellipsis is not centered vertically in commandbar
Notice ellipsis is not the right colors

Workaround

Environment

Nuget Package:

[x] Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia
[ ] Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia
[ ] Uno.SourceGenerationTasks
[ ] Uno.UI.RemoteControl / Uno.WinUI.RemoteControl
[ ] Other:

Nuget Package Version(s): 3.0.12

Affected platform(s):

[x] iOS
[x] Android
[x] WebAssembly
[ ] WebAssembly renderers for Xamarin.Forms
[x] macOS
[x] Skia
- [ ] WPF
- [ ] GTK (Linux)
- [ ] Tizen
[ ] Windows
[ ] Build tasks
[ ] Solution Templates

IDE:

[ ] Visual Studio 2017 (version: )
[x] Visual Studio 2019 (version: 16.6.5)
[ ] Visual Studio for Mac (version: )
[ ] Rider Windows (version: )
[ ] Rider macOS (version: )
[ ] Visual Studio Code (version: )

Relevant plugins:

[ ] Resharper (version: )

Anything else we need to know?

Issue to epic #1665

kazo0 commented 2 years ago

I believe the alignemnt should be fixed now:

As for the colours, yes this looks to still be an issue. Looks like we are using the AppBarButtonForegroundPointerOver instead of AppBarEllipsisButtonForegroundPointerOver, etc.

Also, overriding those resources in the App.xaml I believe won't work, even on Windows. They would need to be set within <CommandBar.Resources/>