[WASM] Changes attached properties needlessly in `ItemsControl.ItemTemplate`

yowl commented 5 years ago

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

in wasm, setting an attached property goes through setting, unsetting, setting whereas it should just set

Expected behavior

Same as UWP, the attachedproperty should not get unset and reset

Minimal reproduction of the problem with instructions

download and run https://github.com/yowl/UnoStandardRefTest/tree/dpmultifire in VS and FF . Press the button and check the console in each. You'll see that UWP is efficient and just sets the Attached Property once, whereas wasm does it 3 times.

Environment

Nuget Package: 
Uno.UI 1.43.0-dev.746
Uno.Wasm.Bootstrap 1.0.0-dev.159
Package Version(s): 

Affected platform(s):
- [ ] iOS
- [ ] Android
- [x ] WebAssembly
- [ ] Windows
- [ ] Build tasks

Visual Studio
- [x ] 2017 (version: )
- [ ] 2017 Preview (version: )
- [ ] for Mac (version: )

Relevant plugins
- [ ] Resharper (version: )

jeromelaban commented 5 years ago

This issue is most likely related to https://github.com/nventive/Uno/issues/382

MartinZikmund commented 6 months ago

This may be fixed now as #382 is fixed, can be verified

agneszitte commented 6 months ago

This may be fixed now as #382 is fixed, can be verified

@Youssef1313 do you think you can help verify this one please?

unoplatform / uno