unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
8.87k stars 716 forks source link

NuGet package override doesn't work for `Uno.UI.Runtime.Skia.Wpf` assembly #5872

Closed mterwoord closed 1 year ago

mterwoord commented 3 years ago

Current behavior

I was trying to work on a simple code change, but wasn't able to use the crosstargetting_override.props file to build into my nuget packages.

Expected behavior

The crosstargetting approach is really neat, as it's easy to change and test things this way.

How to reproduce it (as minimally and precisely as possible)

Set the nuget override version, and build Uno.UI.sln. Lots of things are updated, but not the Uno.Runtime.Skia.Wpf package.

Workaround

Environment

Nuget Package:

Nuget Package Version(s):

Master

Affected platform(s):

IDE:

Relevant plugins:

Anything else we need to know?

jeromelaban commented 3 years ago

Thanks for the report. Does it work for the Skia.Gtk head ?

mterwoord commented 3 years ago

Not sure what I messed up yesterday, but now it seems to work. I'll close this issue.

mterwoord commented 3 years ago

I'm reopening.

Building does change the packages, but Wpf targets don't run then. Gtk does.

mterwoord commented 3 years ago

It expects a different assembly version.

MartinZikmund commented 1 year ago

I think this is working now, can you verify please?

mterwoord commented 1 year ago

Sadly I can't/won't test. I decided to tackle my UI requirements differently, and am no longer using Uno.