unoplatform / uno

Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported.
https://platform.uno
Apache License 2.0
8.67k stars 700 forks source link

[WASM] Use `manifest.json` for `PackageId.Version` #6420

Open ghost opened 3 years ago

ghost commented 3 years ago

What would you like to be added:

If the app has a manifest.json, we should use its version property (if it is defined) for PackageId.Version as opposed to Assembly version.

Why is this needed:

To verify running application version

For which Platform:

Anything else we need to know?

It seems like an odd thing to not be implemented.

MartinZikmund commented 3 years ago

@GRS-Leedo this is surely implementable, the only question is where should the version be coming from. For Android, iOS, UWP, the package version is part of the application manifest. For the web, would you consider the version in manifest.json to be the right one to show up there?

ghost commented 3 years ago

Yes, I believe that would be the one to use.

MartinZikmund commented 1 year ago

This is now implemented by #12596 on all platforms, but on WASM it uses assembly version