[Epic] Breaking changes roundup

MartinZikmund commented 2 years ago

High priority vNext

[ ] Drop non-Skia macOS target
[ ] Drop GTK target
[ ] Drop Fluent V1 styles (https://github.com/unoplatform/uno/pull/14769)
[ ] Drop UWP?

Low priority

[ ] #18672
[ ] https://github.com/unoplatform/uno/pull/18582
[ ] Remove EventsBubblingInManagedCode DP
[ ] Remove RethrowNativeExceptions feature configuration
[ ] Remove DefaultsStartingValueFromAnimatedValue
[ ] #17788
[ ] #17797
[ ] NavigatingCancelEventArgs ctor should not be public
[ ] ComboBox.OnIsDropDownOpenChanged should probably be private protected (verify)
[ ] ItemsControl.OnItemsChanged should have a IVectorChangedEventArgs parameter (and maybe not be protected, but rather private protected [verify this])
[ ] PageStackEntry.SourcePageType setter should not be public
[ ] Frame.BackStack setter should not be public
[ ] WindowActivatedEventArgs.WindowActivationState has wrong type in Uno.WinUI
[ ] Fix UserControl inheritance
[ ] Make PropertyPath sealed (expected by the VS designer)
[ ] Revert https://github.com/unoplatform/uno/pull/17414
[ ] XamlCompositionBrushBase.CompositionBrush should be protected
[ ] Remove UseLegacyHitTest
[ ] FlyoutBase.Close() should be removed. Users should use the public Hide() instead.
[ ] FrameworkPropertyMetadata.DefaultUpdateSourceTrigger should be internal (or, better the whole FrameworkPropertyMetadata)
[ ] Update SkiaSharp to 3.x
[ ] Delete https://github.com/unoplatform/uno/blob/c347914322b295fb672959c5d25c6bdea77fdc0a/src/Uno.UI/UI/Xaml/Automation/AutomationProperties.cs#L44
[ ] IMenu, IMenuPresenter, and ISubMenuOwner should not be public
[ ] For discussion - deprecating the AdaptNative code-path for native element hosting in Android and iOS - causing weird edge cases, and we don't support it officially AFAIK (only explicitly via ContentControl)
[ ] src/Uno.UI/UI/Xaml/Media/BrushConverter.cs should not be browsable (it probably needs to stay public, but users should not see it)
[ ] Border.ChildProperty is not public in WinUI
[ ] #17099
[ ] DoubleCollection shouldn't inherit List<T>. We should use composition instead of inheritance.
[ ] CompositionSpriteShape.StrokeDashArray shouldn't have setter (probably not even internal, and its default value should be non-null, and return type shouldn't be annotated as nullable)
[ ] Remove BypassCheckToCloseKeyboard and its logic from Window.iOS.cs (we should likely default to true behavior to align with other targets)
[ ] Remove invalid ctors from ItemsControlAutomationPeer and SelectorAutomationPeer (keep only WinUI ones)
[ ] CoreWebView2.DocumentTitle setter should be internal or private
[ ] Remove WindowView.ios.cs
[ ] Remove Uno.UI.DataBinding.BinderDetails (https://github.com/unoplatform/uno/pull/16757)
[ ] Remove Microsoft.UI.Composition.DelegatedInkTrailVisual
[ ] Remove UseInvalidateMeasurePath and UseInvalidateArrangePath feature flags. Being always-true shouldn't cause issues.
[ ] Remove TextBox.OnVerticalContentAlignmentChanged override. Maybe make the base OnVerticalContentAlignmentChanged private protected instead of protected.
[ ] In WinUI tree, UseSystemFocusVisuals should be on UIElement. But on UWP tree, it should be on Control.
[ ] Remove feature flag IgnoreINPCSameReferences
[ ] #16148
[ ] Remove non-DP setter support. See https://github.com/unoplatform/uno/pull/16134
[ ] Move Background from FrameworkElement to Control
[x] unoplatform/uno.extensions#2225
[ ] https://github.com/unoplatform/uno/pull/15684
[ ] Remove legacy stuff: https://github.com/unoplatform/uno/tree/master/src/Uno.UI/UI/Xaml/Controls/ListViewBase/Legacy
[ ] https://github.com/unoplatform/uno/blob/2544755918c5916fe4ae2c4928b15989421fb96b/src/Uno.UI.Composition/Composition/VisualInteractionSource.cs#L83-L89
[ ] Investigate whether clr-namespace: can work in WinUI under any scenario. If not, we should remove support for it.
[ ] https://github.com/unoplatform/uno/issues/15508
[ ] Remove Setter<T>
[x] https://github.com/unoplatform/uno/issues/15749
[ ] https://github.com/unoplatform/uno/issues/14858
[ ] https://github.com/unoplatform/uno/issues/14777
[ ] Remove NSObjectExtensions.ValidateDispose
[ ] Decide whether MaterializableList<T> should be internal?
[ ] https://github.com/unoplatform/uno/issues/13046
[ ] https://github.com/unoplatform/uno/issues/13704
[ ] Implement ms-resource:/// conversion of XAML relative Uris parsing for non-framework types (RewriteUri in XamlFileGenerator)
[ ] Fix parent type for RadioMenuFlyoutItem (and undo workaround in UWP SyncGenerator)
[ ] unoplatform/uno#12322
[x] https://github.com/unoplatform/uno/issues/13484
[ ] Unseal Window on Uno.WinUI (part of unoplatform/uno#5286)
[ ] https://github.com/unoplatform/uno/issues/12491
[ ] https://github.com/unoplatform/uno/issues/1833
[ ] Remove EnableExperimentalKeyboardFocus flag on Android (after Android TV PR is merged)
[ ] https://github.com/unoplatform/uno/issues/7114
[ ] https://github.com/unoplatform/uno/issues/13083
[ ] https://github.com/unoplatform/uno/issues/13201
[ ] Would be nice to have - unoplatform/uno#9964
[ ] Remove support for Android native popups (if confirmed by @jeromelaban)
[ ] Remove https://github.com/unoplatform/uno/blob/master/src/Uno.UI/Controls/StyleSelectorCollection.iOS.cs and https://github.com/unoplatform/uno/blob/master/src/Uno.UI/Controls/StyleSelector2.iOS.cs
[ ] https://github.com/unoplatform/uno/issues/12577
[ ] unoplatform/uno#13709
[ ] https://github.com/unoplatform/uno/issues/13050
[ ] https://github.com/unoplatform/uno/issues/13096
[ ] FrameworkElement and ContentControl shouldn't implement IEnumerable.
[ ] Investigate whether IsStatusBarTranslucent in Window.Android.cs can be removed
[ ] https://github.com/unoplatform/uno/blob/3e745977a0eaf7557e2549319cf4e810037055f6/src/Uno.UI/UI/Xaml/Media/Animation/ColorKeyFrameCollection.cs#L27-L37 there shouldn't be throwing setters.
[ ] https://github.com/unoplatform/uno/pull/13867
[ ] unoplatform/uno#13326
[ ] unoplatform/uno#14478
[ ] Drop fluent V1 unoplatform/uno#14765, switch to a non-versioned fluent library
[ ] Remove src/Uno.UWP/Extensions/Vector2Extensions.cs in favor of Uno.Foundation VectorExtensions.cs
[ ] TimePickerFlyoutPresenter should derive from Control not from FlyoutPresenter
[ ] https://github.com/unoplatform/uno/pull/15891
[ ] Microsoft.Windows.ApplicationModel.Resources should not be in Uno.UI - either Uno.UWP or in a separate assembly altogether (MRT Core is now a isolated component of WinAppSDK)
[ ] https://github.com/unoplatform/uno/issues/18875

In Progress (has open PR against the `feature/breaking-changes` branch)

[ ] unoplatform/uno#12563
[ ] https://github.com/unoplatform/uno/pull/12593 (supersedes https://github.com/unoplatform/uno/pull/7649)
[ ] https://github.com/unoplatform/uno/pull/12595 (supersedes https://github.com/unoplatform/uno/pull/12234)
[x] unoplatform/uno#12596 (supersedes unoplatform/uno#12314)
[x] unoplatform/uno#12600 (supersedes unoplatform/uno#12557) (not really a breaking change, and can be done any time)

Merged to `feature/breaking-changes` (these are in Uno 5)

[x] ElevatedView's CornerRadius property is already declared in base Control - it should be enough to observe its changes (#11162)
[x] https://github.com/unoplatform/uno/issues/8910
[x] unoplatform/uno#5513
[x] https://github.com/unoplatform/uno/issues/6895
[x] CreationCollisionOptions values are not aligned with WinRT (https://github.com/unoplatform/uno/discussions/10630) (https://github.com/unoplatform/uno/pull/11169)
[x] HResult type should not be available in C# (https://github.com/unoplatform/uno/pull/11167)
[x] Control.GetImplementedRoutedEvents method should be removed (https://github.com/unoplatform/uno/pull/11165)
[x] https://github.com/unoplatform/uno/pull/11170
[x] https://github.com/unoplatform/uno/pull/11171
[x] Deferral.Close should not be available in C# (according to docs) (https://github.com/unoplatform/uno/pull/11163)
[x] IClosable should not be available in C# (https://github.com/unoplatform/uno/pull/11163)
[x] Uno.Client.ICommandExtensions should most likely not be public (https://github.com/unoplatform/uno/pull/11194)
[x] JavaObjectExtensions should most likely not be public (https://github.com/unoplatform/uno/pull/11196)
[x] Uno.Extensions.UriExtensions should most likely not be public (https://github.com/unoplatform/uno/pull/11193)
[x] https://github.com/unoplatform/uno/issues/10972 (https://github.com/unoplatform/uno/pull/11197)
[x] https://github.com/unoplatform/uno/issues/11136 (https://github.com/unoplatform/uno/pull/11192)
[x] Geolocator: https://github.com/unoplatform/uno/issues/8339#issuecomment-1259205826 (https://github.com/unoplatform/uno/pull/11198)
[x] https://github.com/unoplatform/uno/issues/10841 (https://github.com/unoplatform/uno/pull/11164)
[x] FontFamilyHelper.RemoveUri and RemoveHashFamilyName should not be public (https://github.com/unoplatform/uno/pull/11195)
[x] https://github.com/unoplatform/uno/issues/11127 (https://github.com/unoplatform/uno/pull/11168)
[x] https://github.com/unoplatform/uno/blob/4666c66d75ea47c9156ea79c5d1e83465fdf570d/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs#L871-L873 (#11341)
[x] Move PersonPicture to MUX namespace unoplatform/uno#10701 (#11343)
[x] ICoreWindowEvents should not be public (#11339)
[x] Make the RegisterDefaultStyleXYZ methods in Style internal (#11345)
[x] Remove Skia target host constructors with args parameter (it is ignored anyway) (https://github.com/unoplatform/uno/blob/45c85c08ca4e52dbc62fb11feb19b26996e15bbb/src/Uno.UI.Runtime.Skia.Linux.FrameBuffer/FramebufferHost.cs#L38-L41 https://github.com/unoplatform/uno/blob/45c85c08ca4e52dbc62fb11feb19b26996e15bbb/src/Uno.UI.Runtime.Skia.Gtk/GtkHost.cs#L76-L79) (#11351)
[x] https://github.com/unoplatform/uno/issues/11315 (#11342)
[x] OnVerticalOffsetChanged and OnHorizontalOffsetChanged should not be public in Popup (https://github.com/unoplatform/uno/pull/11355)
[x] https://github.com/unoplatform/uno/issues/11099 (#11344)
[x] RelativePanel.Properties.cs methods have parameters with different name than WinUI (element vs view etc.) (https://github.com/unoplatform/uno/pull/11350)
[x] Remove ViewHelper (https://github.com/unoplatform/uno/pull/9126) (https://github.com/unoplatform/uno/pull/11352)
[x] FrameworkElement constructor should be protected (https://github.com/unoplatform/uno/pull/11354)
[x] Get rid of GetScreenSize method in ViewHelper.iOSmacOS.cs - rename to GetMainWindowSize and make internal (or remove altogether, as we will have multi-window support) (#11353)
[x] https://github.com/unoplatform/uno/pull/11401
[x] unoplatform/uno#11371 (https://github.com/unoplatform/uno/pull/11432)
[x] unoplatform/uno#11372 (https://github.com/unoplatform/uno/pull/11432)
[x] unoplatform/uno#11373 (https://github.com/unoplatform/uno/pull/11432)
[x] unoplatform/uno#11374 (https://github.com/unoplatform/uno/pull/11432)
[x] unoplatform/uno#11375 (https://github.com/unoplatform/uno/pull/11432)
[x] https://github.com/unoplatform/uno/pull/10878
[x] Canvas.Get/Set{Direction} methods with DependencyObject parameters should not be public (or should be removed completely) (#11340)
[x] https://github.com/unoplatform/uno/pull/11510
[x] Make WpfTextViewTextBox internal and move it to Wpf instead of WPF namespace (was taken for 4.8 - https://github.com/unoplatform/uno/pull/10935)
[x] https://github.com/unoplatform/uno/issues/11476 (https://github.com/unoplatform/uno/pull/11583)
[x] https://github.com/unoplatform/uno/issues/11754 (https://github.com/unoplatform/uno/pull/11770)
[x] Uno.UI.Web.WebErrorStatus should not exist and all references should use Windows.Web.WebErrorStatus instead. (https://github.com/unoplatform/uno/pull/12130)
[x] WebView Task<string> InvokeScriptAsync method should be removed, IAsyncOperation<string> version should be kept. unoplatform/uno#12132
[x] https://github.com/unoplatform/uno/pull/12129
[x] Enable strict XAML types resolution by default (avoids fuzzy matching to non fully qualified types) (https://github.com/unoplatform/uno/pull/12135)
[x] Always use type strict search. (https://github.com/unoplatform/uno/pull/12135)
[x] Fix parent type for RadialGradientBrush (and undo workaround in UWP SyncGenerator) (~~https://github.com/unoplatform/uno/pull/7170~~) (https://github.com/unoplatform/uno/pull/12142)
[x] SetContentOffset and SetZoomScale in IUIScrollView can be removed and their implementations as well (https://github.com/unoplatform/uno/pull/12134)
[x] Uno.UI.IndexPath should most likely not be public (https://github.com/unoplatform/uno/pull/12133)
[x] Uno.UI.IResourcesService should most likely not be public (https://github.com/unoplatform/uno/pull/12133)
[x] Uno.UI.Common.DelegateCommand should most likely not be public (https://github.com/unoplatform/uno/pull/12133)
[x] Windows.Foundation.SizeConverter might not need to be public? (https://github.com/unoplatform/uno/pull/12133)
[x] https://github.com/unoplatform/uno/pull/10840
[x] Move ControlsResourcesVersion enum to Uno.UI (https://github.com/unoplatform/uno/pull/12175)
[x] Move GridExtensions to legacy namespace (#12174)
[x] https://github.com/unoplatform/uno/pull/12177
[x] https://github.com/unoplatform/uno/issues/10905 (#12203)
[x] Timeline should be expose IDisposable (https://github.com/CommunityToolkit/Labs-Windows/pull/275) (#12201)
[x] https://github.com/unoplatform/uno/issues/12206 (https://github.com/unoplatform/uno/pull/12224)
[x] https://github.com/unoplatform/uno/issues/9621 (#12153)
[x] https://github.com/unoplatform/uno/pull/12227
[x] https://github.com/unoplatform/uno/issues/12242 (https://github.com/unoplatform/uno/pull/12249)
[x] AnimatedVisualPlayer and IAnimatedVisualSource and related classes should live in the MUX namespaces, not WUX (see https://github.com/unoplatform/uno/pull/11746/commits/8742fb994d5ea44d7767183b0be7283b5a1e9ea6 - these had to be removed from the Generated sources, because otherwise they would be used instead of the actual current implementations in the WUX namespace) (https://github.com/unoplatform/uno/pull/12111)
[x] CreateTheamableFromLottieAsset name is incorrect (https://github.com/unoplatform/uno/pull/12111)
[x] https://github.com/unoplatform/uno/issues/11717 (https://github.com/unoplatform/uno/pull/12111)
[x] https://github.com/unoplatform/uno/pull/12268
[x] https://github.com/unoplatform/uno/pull/12267
[x] https://github.com/unoplatform/uno/pull/12266
[x] Remove IDisposable from MediaPlayerElement.cs (https://github.com/unoplatform/uno/pull/12274)
[x] Make Windows.UI.Xaml.ResourceHelper internal (https://github.com/unoplatform/uno/pull/12197)
[x] Name property should not be on UIElement for Skia and WASM (move to FrameworkElement remove duplicated NameProperty) (#12248)
[x] https://github.com/unoplatform/uno/pull/12070
[x] Remove LoadActions/UnloadActions (see with @ebariche) (https://github.com/unoplatform/uno/pull/12287)
[x] https://github.com/unoplatform/uno/issues/11662 (https://github.com/unoplatform/uno/pull/12214)
[x] https://github.com/unoplatform/uno/issues/12213 (https://github.com/unoplatform/uno/pull/12214)
[x] Ensure Sync Generator runs correctly against MUX version of PersonPicture and AnimatedVisualPlayer (https://github.com/unoplatform/uno/pull/12293)
[x] Measure/Arrange shouldn't be virtual (https://github.com/unoplatform/uno/pull/12294)
[x] Move MenuBar and MenuBarItem and MenuBarFlyoutItem implementation from WUX namespace to MUX namespace and add warning for unsupported WUX version (https://github.com/unoplatform/uno/pull/12113)
[x] https://github.com/unoplatform/uno/pull/12436
[x] Move SwipeControl and SwipeItem and SwipeItemInvokedEventArgs and SwipeMode and SwipeItems and SwipeBehaviorOnInvoked implementation from WUX namespace to MUX namespace and add warning for unsupported WUX version (#12112)
[x] https://github.com/unoplatform/uno/pull/11254
[x] https://github.com/unoplatform/uno/issues/11241 (#11338)
[x] https://github.com/unoplatform/uno/pull/12589 (supersedes unoplatform/uno#11452)
[x] unoplatform/uno#12588 (supersedes https://github.com/unoplatform/uno/pull/7249 and https://github.com/unoplatform/uno/pull/12261)
[x] https://github.com/unoplatform/uno/pull/12594 (supersedes https://github.com/unoplatform/uno/pull/12196)
[x] unoplatform/uno#12597 (supersedes unoplatform/uno#12354)
[x] unoplatform/uno#13708
[x] https://github.com/unoplatform/uno/issues/2983
[x] https://github.com/unoplatform/uno/issues/12840

For which Platform:

All

Youssef1313 commented 2 years ago

Consider removing this in the next major release:

https://github.com/unoplatform/uno/blob/4666c66d75ea47c9156ea79c5d1e83465fdf570d/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs#L871-L873

Youssef1313 commented 2 years ago

Also https://github.com/unoplatform/uno/blob/master/src/Uno.Foundation/HResult.cs

I think it should be removed. It's unused, and https://docs.microsoft.com/en-us/uwp/api/windows.foundation.hresult?view=winrt-22621 says:

When programming with .NET, this class is hidden

GitHub
uno/HResult.cs at master · unoplatform/uno
Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - uno/HResult.cs at master · unoplatform/uno

HResult Struct (Windows.Foundation) - Windows UWP applications
Represents a Windows Runtime error. .NET When programming with .NET, this type is hidden, and exceptions appear as System.Exception or specific derived exception types. See Remarks.

Youssef1313 commented 2 years ago

It might also be a good idea to not expose HtmlImage publicly

https://github.com/unoplatform/uno/blob/88d7a4024ccdcaa07a6b8cd056ba55ef4e92865e/src/Uno.UI/UI/Xaml/Controls/Image/Image.wasm.cs#L17-L22

It should be used only by Uno, I think

Youssef1313 commented 2 years ago

Also https://github.com/unoplatform/uno/blob/88d7a4024ccdcaa07a6b8cd056ba55ef4e92865e/src/Uno.UI/UI/Xaml/Controls/Control/Control.cs#L997-L998

Youssef1313 commented 2 years ago

We should also delete those:

https://github.com/unoplatform/uno/blob/7cc2df180fb8b5833f3f6e05b50ac8d4ed4a8e99/src/Uno.UWP/Devices/Geolocation/Geolocator.iOSmacOS.cs#L183-L185

They don't match UWP signature and are not implemented properly

Youssef1313 commented 2 years ago

CornerRadius and CornerRadiusProperty should be removed from ElevatedView. See https://github.com/unoplatform/uno/pull/10138#discussion_r996273357

Youssef1313 commented 1 year ago

@MartinZikmund I assume these will go into Uno 5 (next major release)? If so, should we have a branch to work on these earlier?

MartinZikmund commented 1 year ago

@MartinZikmund I assume these will go into Uno 5 (next major release)? If so, should we have a branch to work on these earlier?

I think that is a good idea, let's make PRs for them targeting this branch - https://github.com/unoplatform/uno/tree/dev/5.0-breaking-changes

GitHub
GitHub - unoplatform/uno at dev/5.0-breaking-changes
Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - GitHub - unoplatform/uno at dev/5.0-breaking-changes

jeromelaban commented 1 year ago

For breaking changes let's use a branch named feature/breaking-changes instead, the CI is already setup properly.

Youssef1313 commented 1 year ago

Great. I renamed the branch Martin created: https://github.com/unoplatform/uno/tree/feature/breaking-changes.

I'm going to start working on some of the changes soon.

GitHub
GitHub - unoplatform/uno at feature/breaking-changes
Build Mobile, Desktop and WebAssembly apps with C# and XAML. Today. Open source and professionally supported. - GitHub - unoplatform/uno at feature/breaking-changes

unoplatform / uno