search

unoplatform / uno

Open-source platform for building cross-platform native Mobile, Web, Desktop and Embedded apps quickly. Create rich, C#/XAML, single-codebase apps from any IDE. Hot Reload included! 90m+ NuGet Downloads!!
https://platform.uno
Apache License 2.0
8.9k stars 720 forks source link

[Gallery][iOS/Android] Overview - At the bottom of the page 'Share' link is not working #9012

Open sakshi173 opened 2 years ago

sakshi173 commented 2 years ago

Current behavior

Share link

Expected behavior

when click/tap on the share link the page should be available to share.

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Go to the 'Overview' Page.
  3. Scroll down to the 'Overview' Page.
  4. Go to the 'Share' link at the bottom of the page.
  5. Tap/click on the 'Share' link.
  6. Observe that nothing is happening.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

iOS, Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Xiaoy312 commented 2 years ago

working fine on:

sakshi173 commented 2 years ago

Still this bug is reproducible, due to that opening it.

agneszitte commented 1 year ago

@sakshi173 is this issue still reproducible lately please?

sakshi173 commented 1 year ago

@agneszitte-nventive Yes this issue is still present. Please look into it.

agneszitte commented 1 year ago

@agneszitte-nventive Yes this issue is still present. Please look into it.

Thanks a lot for the update @sakshi173 really appreciated it!

rajamatt commented 1 year ago

@kazo0 Can't repro this for iOS or Android. Clicking on share link opens native share menu.

iOS: iphone 11 iOS 15 Android: Samsung galaxy A14 Android 13.0

kazo0 commented 1 year ago

@sakshi173 you're seeing this on mobile devices or on a web browser?

sakshi173 commented 1 year ago

@rajamatt and @kazo0 , I am seeing in mobile device and when clicking on share link nothing is happening.

https://github.com/unoplatform/uno/assets/74563602/01c5ed70-6d7e-4a04-a250-e3ce8f41bc69

rajamatt commented 1 year ago

Thank you @sakshi173

@kazo0 I'll let you decide what's next for this issue as I can't repro it, I tried looking in the code and changing stuff but nothing looks out of place

MartinZikmund commented 1 year ago

@sakshi173 Which iOS version is this? And does it still repro on Android too?

sakshi173 commented 1 year ago

@MartinZikmund , Yes Still this issue is present for both Android and iOS. I am checking for iOS version 15.6.1 and Model is iphone 13 pro Max.

Youssef1313 commented 1 year ago

Looking at the code, it's expected this is happening:

https://github.com/unoplatform/Uno.Gallery/blob/9fb342c26e0648332eb0adfb62dd2be0b343d950/Uno.Gallery/Uno.Gallery.Shared/Controls/SamplePageLayout.cs#L167-L173

It only works for !NET6_0_OR_GREATER, which means it used to work only for Xamarin targets which are gone now.

Youssef1313 commented 1 year ago

I'm looking into it

Youssef1313 commented 1 year ago

Fix for Android: https://github.com/unoplatform/Uno.Gallery/pull/942 I couldn't get iOS working though. Not very familiar with iOS APIs and I think I might be doing something very wrong, though I left the code I wrote in #942 as a starting point (if needed).

Arieldelossantos commented 1 year ago

yes, i've noticed too that it was removed on .Net6 upgrade... i was trying to find a workaround based on this documentation from Uno... Sharing Content

Youssef1313 commented 1 year ago

@Arieldelossantos Oh I didn't know about that! I think your approach could work better. I'll mark my PR as a draft then.