search

unosquare / embedio

A tiny, cross-platform, module based web server for .NET
http://unosquare.github.io/embedio
Other
1.46k stars 176 forks source link

Fix removal of prefixes in EndPointListener #463

Closed desistud closed 4 years ago

desistud commented 4 years ago

Fix issue with checking for ListenerPrefix by instance.

Fixes https://github.com/unosquare/embedio/issues/421#issuecomment-595929669

rdeago commented 4 years ago

Good catch and good fix @desistud!

Writing a comparer to use in the prefixes dictionary would have made the code a little cleaner, but the fix is good as it is.

EmbedIO version 4 will have no prefixes, so this fix needs no porting to master.

geoperez commented 4 years ago

Do we need to release a new v3.X nuget?

rdeago commented 4 years ago

Definitely. This fixes both #421 and #459, or at least fixes the former, and provides a better starting point for debugging the latter.

desistud commented 4 years ago

I would certainly like a new release of 3.X so I can incorporate these changes.

Also, I believe this also address issue https://github.com/unosquare/embedio/issues/402

rdeago commented 4 years ago

Also, I believe this also address issue #402

Yeah, that, too! Triple kudos to @desistud!

(Also, an honorable mention to @SaricVr who did a similar fix for #459, even if he didn't open a PR)

geoperez commented 4 years ago

Sorry, I didn't notice that I need to push a new Nuget.

rishabh14augshukla commented 4 years ago

@geoperez Is socket exception issue resolve in the 3.4.3 version?

geoperez commented 4 years ago

It should be.

rishabh14augshukla commented 4 years ago

@geoperez it does not work. DO I need to change anything in the code side ? Please let me know