unosquare / embedio

A tiny, cross-platform, module based web server for .NET
http://unosquare.github.io/embedio
Other
1.46k stars 176 forks source link

Add WWW-Authenticate header to 401 responses #517

Closed duddo closed 3 years ago

duddo commented 3 years ago

Fixing issue https://github.com/unosquare/embedio/issues/516 by adding the WWW-Authenticate header to responses.

rdeago commented 3 years ago

Hello @duddo, thanks for the PR! You could commit on your previous PR's branch and GitHub would have updated everything accordingly, no need for a separate branch. Anyway, OK, I'll keep this one and close #515.

duddo commented 3 years ago

Hello @rdeago, happy to help! I issued two separate PR targeting the 3.x and the master branch, since I saw the problem was in both. I caught it first into the nuget package, then I discovered it was present in master too.

rdeago commented 3 years ago

@duddo you're right, I just reopened @515 so you can commit the corrected tests on that one too. I apologize for overlooking the target branch.