search

unosquare / embedio

A tiny, cross-platform, module based web server for .NET
http://unosquare.github.io/embedio
Other
1.46k stars 176 forks source link

PR with fixes of some issues #534

Closed radioegor146 closed 2 years ago

radioegor146 commented 2 years ago

Fixes #531 Fixes #528 Fixes #519 Fixes #504 Fixes #502 Fixes #487 Fixes tests on GH Actions

radioegor146 commented 2 years ago

@rdeago also, are there any plans or possible time of release v4.0? Or I can continue to fix that library/add new features from the current state?

rdeago commented 2 years ago

We will definitely need a backport of these changes to the v3 branch!

radioegor146 commented 2 years ago

Great job @radioegor146! Please forgive me for taking so long to review.

Being a fan of simplification, I especially like ListenerUri. 😃

Just remove the two added usings here if they are not necessary. Otherwise, this PR is absolutely to be merged IMO.

I've fixed some changes. Also, the added chcp command is to make sure that netsh output is in the simplest possible encoding (CP437/OEM), just because on systems with other default regional settings (as mine - ru_RU), the error message is really unreadable.

rdeago commented 2 years ago

@rdeago also, are there any plans or possible time of release v4.0? Or I can continue to fix that library/add new features from the current state?

Unfortunately, no 4.0 release in sight at the moment, but I'm going to submit a PR that backports your changes to the v3.x branch.

dtsirkovmb commented 2 years ago

Hi @rdeago, do you have any idea when will backports to v3.x take place? Cheers.

rdeago commented 2 years ago

@dtsirkovmb I'm on it. I also found a couple other things in need of a fix, the PR should be ready by Monday.